implement update pythonpath and environment at LS initialization

Author: d-biehl

robotcode/language_server/common/parts/workspace.py

@@ -150,8 +150,8 @@ def __init__(
         self.root_uri = root_uri
 
         self.root_path = root_path
-        self.workspace_folders_lock = Lock()
-        self.workspace_folders: List[WorkspaceFolder] = (
+        self._workspace_folders_lock = Lock()
+        self._workspace_folders: List[WorkspaceFolder] = (
             [WorkspaceFolder(w.name, Uri(w.uri), w.uri) for w in workspace_folders]
             if workspace_folders is not None
             else []
@@ -164,6 +164,10 @@ def __init__(
         self.parent.on_shutdown.add(self._on_shutdown)
         self._config_cache = AsyncSimpleLRUCache(max_items=1000)
 
+    @property
+    def workspace_folders(self) -> List[WorkspaceFolder]:
+        return self._workspace_folders
+
     @_logger.call
     async def _on_shutdown(self, sender: Any) -> None:
         for e in self._file_watchers.copy():
@@ -374,19 +378,19 @@ async def _workspace_did_change_workspace_folders(
         self, event: WorkspaceFoldersChangeEvent, *args: Any, **kwargs: Any
     ) -> None:
 
-        async with self.workspace_folders_lock:
+        async with self._workspace_folders_lock:
             to_remove: List[WorkspaceFolder] = []
             for removed in event.removed:
-                to_remove += [w for w in self.workspace_folders if w.uri == removed.uri]
+                to_remove += [w for w in self._workspace_folders if w.uri == removed.uri]
 
             for removed in event.added:
-                to_remove += [w for w in self.workspace_folders if w.uri == removed.uri]
+                to_remove += [w for w in self._workspace_folders if w.uri == removed.uri]
 
             for r in to_remove:
-                self.workspace_folders.remove(r)
+                self._workspace_folders.remove(r)
 
             for a in event.added:
-                self.workspace_folders.append(WorkspaceFolder(a.name, Uri(a.uri), a.uri))
+                self._workspace_folders.append(WorkspaceFolder(a.name, Uri(a.uri), a.uri))
 
     @async_event
     async def did_change_watched_files(sender, changes: List[FileEvent]) -> None:  # NOSONAR

robotcode/language_server/robotframework/diagnostics/library_doc.py

@@ -16,6 +16,7 @@
 from typing import (
     AbstractSet,
     Any,
+    ClassVar,
     Dict,
     Iterable,
     Iterator,
@@ -283,9 +284,6 @@ def resolve(
         )
         resolver.resolve(arguments, variables)
 
-    def __hash__(self) -> int:
-        return id(self)
-
 
 @dataclass
 class KeywordDoc(SourceEntity):
@@ -436,7 +434,6 @@ def is_run_keywords(self) -> bool:
         return self.libname == BUILTIN_LIBRARY_NAME and self.name == RUN_KEYWORDS_NAME
 
     def __hash__(self) -> int:
-        # return id(self)
         return hash(
             (
                 self.name,
@@ -607,12 +604,12 @@ def source_or_origin(self) -> Optional[str]:
 
         return None
 
-    _inline_link: re.Pattern = re.compile(  # type: ignore
+    _inline_link: ClassVar[re.Pattern] = re.compile(  # type: ignore
         r"([\`])((?:\1|.)+?)\1",
         re.VERBOSE,
     )
 
-    _headers: re.Pattern = re.compile(r"^(={1,5})\s+(\S.*?)\s+\1$", re.MULTILINE)  # type: ignore
+    _headers: ClassVar[re.Pattern] = re.compile(r"^(={1,5})\s+(\S.*?)\s+\1$", re.MULTILINE)  # type: ignore
 
     def _process_inline_links(self, text: str) -> str:
         headers = [v.group(2) for v in self._headers.finditer(text)]
@@ -706,7 +703,7 @@ class VariablesDoc(LibraryDoc):
 
 
 def is_library_by_path(path: str) -> bool:
-    return path.lower().endswith((".py", ".java", ".class", "/", os.sep))
+    return path.lower().endswith((".py", "/", os.sep))
 
 
 def is_variables_by_path(path: str) -> bool:
@@ -1327,7 +1324,9 @@ def get_test_library(
                             is_registered_run_keyword=RUN_KW_REGISTER.is_run_keyword(libdoc.name, kw[0].name),
                             args_to_process=RUN_KW_REGISTER.get_args_to_process(libdoc.name, kw[0].name),
                             deprecated=kw[0].deprecated,
-                            arguments=ArgumentSpec.from_robot_argument_spec(kw[1].arguments),
+                            arguments=ArgumentSpec.from_robot_argument_spec(kw[1].arguments)
+                            if not kw[1].is_error_handler
+                            else None,
                         )
                         for kw in [
                             (KeywordDocBuilder().build_keyword(k), k)

robotcode/language_server/robotframework/protocol.py

@@ -1,4 +1,7 @@
+import os
+import sys
 from dataclasses import dataclass
+from pathlib import Path
 from typing import TYPE_CHECKING, Any, Optional
 
 from ..._version import __version__
@@ -12,6 +15,7 @@
 from ..common.lsp_types import InitializeError, Model
 from ..common.parts.document_symbols import symbol_information_label
 from ..common.protocol import LanguageServerProtocol
+from .configuration import RobotConfig
 from .parts.codelens import RobotCodeLensProtocolPart
 from .parts.completion import RobotCompletionProtocolPart
 from .parts.debugging_utils import RobotDebuggingUtilsProtocolPart
@@ -106,6 +110,7 @@ def __init__(self, server: "RobotLanguageServer"):
         super().__init__(server)
         self.options = Options()
         self.on_initialize.add(self._on_initialize)
+        self.on_initialized.add(self._on_initialized)
         self.on_shutdown.add(self._on_shutdown)
 
     @_logger.call
@@ -125,3 +130,21 @@ async def _on_initialize(self, sender: Any, initialization_options: Optional[Any
             self.options = from_dict(initialization_options, Options)
 
         self._logger.debug(f"initialized with {repr(self.options)}")
+
+    async def _on_initialized(self, sender: Any) -> None:
+        for folder in self.workspace.workspace_folders:
+            config: RobotConfig = await self.workspace.get_configuration(RobotConfig, folder.uri)
+            if config is not None:
+                if config.env:
+                    for k, v in config.env.items():
+                        os.environ[k] = v
+
+                if config.python_path:
+                    for p in config.python_path:
+                        pa = Path(p)
+                        if not pa.is_absolute():
+                            pa = Path(folder.uri.to_path(), pa)
+
+                        absolute_path = str(pa.absolute())
+                        if absolute_path not in sys.path:
+                            sys.path.insert(0, absolute_path)