use synchronous methods for getting documents in discovering

Author: d-biehl

robotcode/jsonrpc2/protocol.py

@@ -482,8 +482,6 @@ def done(f: asyncio.Future[Any]) -> None:
                 if ex is None or isinstance(ex, asyncio.CancelledError):
                     return
 
-                # self._logger.exception(ex, exc_info=ex)
-
         for m in iterator:
             create_sub_task(self.handle_message(m)).add_done_callback(done)
 

robotcode/language_server/common/parts/diagnostics.py

@@ -102,7 +102,7 @@ def extend_capabilities(self, capabilities: ServerCapabilities) -> None:
         ):
             capabilities.diagnostic_provider = DiagnosticOptions(
                 inter_file_dependencies=True,
-                workspace_diagnostics=False,
+                workspace_diagnostics=True,
                 identifier=f"robotcodelsp_{uuid.uuid4()}",
                 work_done_progress=True,
             )
@@ -350,7 +350,6 @@ async def _task(doc: TextDocument) -> None:
 
                 return WorkspaceDiagnosticReport(items=[])
 
-        await self.in_get_document_diagnostics.wait()
         self.in_get_workspace_diagnostics.clear()
         try:
             await self.ensure_workspace_loaded()

robotcode/language_server/common/parts/documents.py

@@ -182,9 +182,12 @@ async def did_change(sender, document: TextDocument) -> None:  # NOSONAR
     async def did_save(sender, document: TextDocument) -> None:  # NOSONAR
         ...
 
+    def get_sync(self, _uri: Union[DocumentUri, Uri]) -> Optional[TextDocument]:
+        return self._documents.get(str(Uri(_uri).normalized() if not isinstance(_uri, Uri) else _uri), None)
+
     async def get(self, _uri: Union[DocumentUri, Uri]) -> Optional[TextDocument]:
         async with self._lock:
-            return self._documents.get(str(Uri(_uri).normalized() if not isinstance(_uri, Uri) else _uri), None)
+            return self.get_sync(_uri)
 
     def __len__(self) -> int:
         return self._documents.__len__()

robotcode/language_server/common/text_document.py

@@ -70,6 +70,9 @@ def __repr__(self) -> str:  # pragma: no cover
             f")"
         )
 
+    def text_sync(self) -> str:
+        return self._text
+
     async def text(self) -> str:
         async with self._lock:
             return self._text

robotcode/language_server/robotframework/parts/discovering.py

@@ -135,11 +135,9 @@ async def _get_tests_from_workspace(
 
         def get_document_text(source: str) -> str:
             if self.parent._loop:
-                doc = asyncio.run_coroutine_threadsafe(
-                    self.parent.documents.get(Uri.from_path(source).normalized()), self.parent._loop
-                ).result()
+                doc = self.parent.documents.get_sync(Uri.from_path(source).normalized())
                 if doc is not None and doc.opened_in_editor:
-                    return asyncio.run_coroutine_threadsafe(doc.text(), self.parent._loop).result()
+                    return doc.text_sync()
 
             return source