Rename getOrElse -> getWithDefault, has -> isSome, isEmpty -> isNone

Author: arnarthor

jscomp/others/belt_Option.ml

@@ -45,14 +45,14 @@ let flatMapU opt f = match opt with
 
 let flatMap opt f = flatMapU opt (fun[@bs] x -> f x)
 
-let getOrElse opt default = match opt with
+let getWithDefault opt default = match opt with
   | Some x -> x
   | None -> default
 
-let has = function
+let isSome = function
   | Some _ -> true
   | None -> false
 
-let isEmpty = function
+let isNone = function
   | Some _ -> false
   | None -> true

jscomp/others/belt_Option.mli

@@ -34,6 +34,6 @@ val mapU : 'a option -> ('a -> 'b [@bs]) -> 'b option
 val map : 'a option -> ('a -> 'b) -> 'b option
 val flatMapU : 'a option -> ('a -> 'b option [@bs]) -> 'b option
 val flatMap : 'a option -> ('a -> 'b option) -> 'b option
-val getOrElse : 'a option -> 'a -> 'a
-val has : 'a option -> bool
-val isEmpty : 'a option -> bool
+val getWithDefault : 'a option -> 'a -> 'a
+val isSome : 'a option -> bool
+val isNone : 'a option -> bool

lib/js/belt_Option.js

@@ -46,23 +46,23 @@ function flatMap(opt, f) {
   return flatMapU(opt, Curry.__1(f));
 }
 
-function getOrElse(opt, $$default) {
+function getWithDefault(opt, $$default) {
   if (opt) {
     return opt[0];
   } else {
     return $$default;
   }
 }
 
-function has(param) {
+function isSome(param) {
   if (param) {
     return /* true */1;
   } else {
     return /* false */0;
   }
 }
 
-function isEmpty(param) {
+function isNone(param) {
   if (param) {
     return /* false */0;
   } else {