tweak

Author: bobzhang

jscomp/core/js_output.ml

@@ -117,14 +117,14 @@ let to_break_block (x : t) : J.block * bool =
     let block = unnest_block x.block in 
     match x with 
     | {finished = True;  _ } -> 
-        block, false 
+        block, false
        (* value does not matter when [finished] is true
            TODO: check if it has side efects
         *)
     | { value =  None; finished } -> 
         block, (match finished with | True -> false | (False | Dummy)  -> true  )
 
-    | {value = opt; _} -> 
+    | {value = Some _ as opt; _} -> 
         block_with_opt_expr block opt, true
 
 

jscomp/core/js_output.mli

@@ -65,6 +65,21 @@ val output_as_block :
 val to_break_block :
   t ->
   J.block * bool 
+  (* the second argument is 
+    [true] means [break] needed
+
+    When we know the output is gonna finished true
+    we can reduce 
+    {[
+      return xx ; 
+      break
+    ]}
+    into 
+    {[
+      return ; 
+    ]}
+
+  *)
 
 val append_output: t -> t -> t   
 

lib/whole_compiler.ml

@@ -87926,6 +87926,21 @@ val output_as_block :
 val to_break_block :
   t ->
   J.block * bool 
+  (* the second argument is 
+    [true] means [break] needed
+
+    When we know the output is gonna finished true
+    we can reduce 
+    {[
+      return xx ; 
+      break
+    ]}
+    into 
+    {[
+      return ; 
+    ]}
+
+  *)
 
 val append_output: t -> t -> t   
 
@@ -88077,14 +88092,14 @@ let to_break_block (x : t) : J.block * bool =
     let block = unnest_block x.block in 
     match x with 
     | {finished = True;  _ } -> 
-        block, false 
+        block, false
        (* value does not matter when [finished] is true
            TODO: check if it has side efects
         *)
     | { value =  None; finished } -> 
         block, (match finished with | True -> false | (False | Dummy)  -> true  )
 
-    | {value = opt; _} -> 
+    | {value = Some _ as opt; _} -> 
         block_with_opt_expr block opt, true