better names

Author: bobzhang

jscomp/core/lam_compile_external_obj.ml

@@ -40,9 +40,9 @@ module S = Js_stmt_make
 *)
 
 (* TODO: check stackoverflow *)
-let assemble_obj_args (labels : External_arg_spec.t list)  (args : J.expression list) 
+let assemble_obj_args (labels : External_arg_spec.obj_params)  (args : J.expression list) 
   : J.block * J.expression = 
-   let rec aux (labels : External_arg_spec.t list) args 
+   let rec aux (labels : External_arg_spec.obj_params) args 
     : (Js_op.property_name * E.t ) list  * J.expression list * _ = 
     match labels, args with 
     | [] , []  ->  [], [], []
@@ -101,7 +101,7 @@ let assemble_obj_args (labels : External_arg_spec.t list)  (args : J.expression
       | x::xs -> E.seq (E.fuse_to_seq x xs) (E.obj map)     
     end) :: 
       (Ext_list.flat_map assignment (fun 
-        ((xlabel : External_arg_spec.t), (arg  : J.expression )) -> 
+        ((xlabel : External_arg_spec.obj_param), (arg  : J.expression )) -> 
       match xlabel with 
       | {arg_label = Optional {name = label} } -> 
         (* Need make sure whether assignment is effectful or not

jscomp/core/lam_compile_external_obj.mli

@@ -38,7 +38,7 @@
  *)
 
 val assemble_obj_args :
-  External_arg_spec.t list -> 
+  External_arg_spec.obj_params -> 
   J.expression list -> 
   J.block * J.expression 
 (* It returns a block in cases we need set the property dynamically: we need

jscomp/core/lam_primitive.ml

@@ -49,7 +49,7 @@ type t =
       { prim_name : string ;
         arg_types : External_arg_spec.params ;
         ffi : External_ffi_types.external_spec }
-  | Pjs_object_create of External_arg_spec.t list
+  | Pjs_object_create of External_arg_spec.obj_params
   (* Exceptions *)
   | Praise
   (* Boolean operations *)

jscomp/core/lam_primitive.mli

@@ -48,7 +48,7 @@ type t =
     { prim_name : string;
       arg_types : External_arg_spec.params ;
       ffi : External_ffi_types.external_spec}
-  | Pjs_object_create of External_arg_spec.t list
+  | Pjs_object_create of External_arg_spec.obj_params
 
   | Praise 
   | Psequand | Psequor | Pnot

jscomp/syntax/ast_external_process.ml

@@ -963,7 +963,7 @@ let handle_attributes_as_string
 
 let pval_prim_of_labels (labels : string Asttypes.loc list) =
   let arg_kinds =
-    Ext_list.fold_right labels ([] : External_arg_spec.t list ) 
+    Ext_list.fold_right labels ([] : External_arg_spec.obj_params ) 
       (fun {loc ; txt } arg_kinds
         ->
           let arg_label =

jscomp/syntax/external_arg_spec.ml

@@ -57,20 +57,20 @@ type attr =
   | Ignore
   | Unwrap
 
-type t_noname = {
+type param = {
   arg_type : attr;
   arg_label : label_noname
 }   
 
-type t = 
+type obj_param = 
   {
     arg_type : attr;
     arg_label : label
   }
 
 
-
-type params = t_noname list 
+type obj_params = obj_param list 
+type params = param list 
 
 exception Error of Location.t * Ext_json_parse.error
 

jscomp/syntax/external_arg_spec.mli

@@ -56,17 +56,19 @@ type label_noname =
   | Arg_empty 
   | Arg_optional
 
-type t = 
+type obj_param = 
   {
     arg_type : attr;
     arg_label :label
   }
 
-type t_noname = {
+type param = {
   arg_type : attr;
   arg_label : label_noname
 } 
-type params = t_noname list 
+
+type obj_params = obj_param list 
+type params = param list 
 
 val cst_json : Location.t -> string -> cst 
 val cst_int : int -> cst 
@@ -76,4 +78,4 @@ val empty_label : label
 val empty_lit : cst -> label 
 val label :  string -> cst option -> label
 val optional  : string -> label
-val empty_kind : attr -> t
+val empty_kind : attr -> obj_param

jscomp/syntax/external_ffi_types.ml

@@ -126,7 +126,7 @@ type t  =
        [return] means return value is unit or not,
         [true] means is [unit]
   *)
-  | Ffi_obj_create of  External_arg_spec.t list
+  | Ffi_obj_create of  External_arg_spec.obj_params
   | Ffi_inline_const of Lam_constant.t
   | Ffi_normal
   (* When it's normal, it is handled as normal c functional ffi call *)

jscomp/syntax/external_ffi_types.mli

@@ -105,7 +105,7 @@ type t  =
       External_arg_spec.params  *
       return_wrapper *
       external_spec
-  | Ffi_obj_create of External_arg_spec.t list
+  | Ffi_obj_create of External_arg_spec.obj_params
   | Ffi_inline_const of Lam_constant.t
   | Ffi_normal
   (* When it's normal, it is handled as normal c functional ffi call *)