move sexp into ext so that we can do lambda optimization unit test in the future (#1049)

* more string_hashtbl testing and moving sexp parser for lambda to ext

* more unit tests for sexp parser

Author: bobzhang

jscomp/Makefile

@@ -137,6 +137,7 @@ OUNIT_TESTS_SRCS =  ounit_tests_util \
 	ounit_vec_test \
 	ounit_string_tests\
 	ounit_topsort_tests\
+	ounit_sexp_tests\
 	ounit_tests_main
 OUNIT_TESTS_CMXS = $(addprefix ounit_tests/, $(addsuffix .cmx, $(OUNIT_TESTS_SRCS)))
 
@@ -180,6 +181,7 @@ EXT_SRCS = ext_util\
 	ext_topsort\
 	ext_pp_scope\
 	ext_io\
+	ext_sexp\
 	ident_hash_set\
 	hash_set_poly\
 	ident_hashtbl\
@@ -224,7 +226,7 @@ CORE_CMXS=$(addprefix core/, $(addsuffix .cmx, $(CORE_SRCS)))
 OTHER_CORE_SRCS= bsppx_main bspack_main jsoo_main  bspp_main js_cmi_datasets \
 		 js_main
 OTHER_CORE_CMXS= $(addprefix core/, $(addsuffix .cmx, $(OTHER_CORE_SRCS)))
-BSB_SRCS= bsb_config bsb_build_schemas bsb_build_util bsb_dep_infos bsb_dir bsb_json sexp_lexer sexp_eval  bsb_ninja bsb_build_ui bsb_default bsb_gen
+BSB_SRCS= bsb_config bsb_build_schemas bsb_build_util bsb_dep_infos bsb_dir bsb_json bsb_ninja bsb_build_ui bsb_default bsb_gen
 
 BSB_CMXS=$(addprefix bsb/, $(addsuffix .cmx, $(BSB_SRCS)))
 MAIN_SRCS= jsgen_main jscmj_main bsb/bsb_main bsb/bsb_helper_main
@@ -476,7 +478,7 @@ include all.depend
 -include $(SNAPSHOT_DEPS)
 
 clean:
-	rm -f bsb/bs_json.ml bsb/sexp_lexer.ml core/js_fold.ml core/js_map.ml
+	rm -f bsb/bs_json.ml ext/sexp_lexer.ml core/js_fold.ml core/js_map.ml
 	rm -f common/bs_version.ml
 	rm -rf bin/config_whole_compiler.ml
 	git clean -dfx stubs ext common syntax depends core bsb

jscomp/all.depend

@@ -64,6 +64,7 @@ ext/ext_topsort.cmx : ext/set_int.cmx ext/resize_array.cmx ext/int_vec.cmx \
 ext/ext_pp_scope.cmx : ext/string_map.cmx ext/int_map.cmx ext/ident_set.cmx \
     ext/ext_pp_scope.cmi
 ext/ext_io.cmx : ext/ext_pervasives.cmx ext/ext_io.cmi
+ext/ext_sexp.cmx : ext/ext_sexp.cmi
 ext/ident_hash_set.cmx : ext/hash_set_gen.cmx ext/ext_ident.cmx \
     stubs/bs_hash_stubs.cmx ext/ident_hash_set.cmi
 ext/hash_set_poly.cmx : ext/hash_set_gen.cmx ext/hash_set_poly.cmi
@@ -116,6 +117,7 @@ ext/ext_scc.cmi : ext/int_vec_vec.cmi ext/int_vec.cmi
 ext/ext_topsort.cmi : ext/vec_gen.cmx ext/set_int.cmi ext/int_vec.cmi
 ext/ext_pp_scope.cmi : ext/ident_set.cmi
 ext/ext_io.cmi :
+ext/ext_sexp.cmi :
 ext/ident_hash_set.cmi : ext/hash_set_gen.cmx
 ext/hash_set_poly.cmi :
 ext/ident_hashtbl.cmi : ext/hashtbl_gen.cmx
@@ -586,8 +588,8 @@ ounit_tests/ounit_hash_stubs_test.cmx : ounit_tests/ounit_tests_util.cmx \
 ounit_tests/ounit_hash_set_tests.cmx : ext/string_hash_set.cmx \
     ext/ordered_hash_set_string.cmx ounit/oUnit.cmx ext/hash_set_poly.cmx \
     ext/hash_set.cmx
-ounit_tests/ounit_scc_tests.cmx : ounit/oUnit.cmx ext/int_vec_vec.cmx \
-    ext/int_vec.cmx ext/ext_string.cmx ext/ext_scc.cmx
+ounit_tests/ounit_scc_tests.cmx : ext/string_hashtbl.cmx ounit/oUnit.cmx \
+    ext/int_vec_vec.cmx ext/int_vec.cmx ext/ext_string.cmx ext/ext_scc.cmx
 ounit_tests/ounit_hashtbl_tests.cmx : ext/string_hashtbl.cmx ounit/oUnit.cmx
 ounit_tests/ounit_json_tests.cmx : ext/string_map.cmx ounit/oUnit.cmx \
     bsb/bsb_json.cmx
@@ -599,10 +601,12 @@ ounit_tests/ounit_vec_test.cmx : ext/set_int.cmx ounit/oUnit.cmx \
 ounit_tests/ounit_string_tests.cmx : ounit/oUnit.cmx ext/ext_string.cmx
 ounit_tests/ounit_topsort_tests.cmx : ext/set_int.cmx ounit/oUnit.cmx \
     ext/int_vec.cmx ext/ext_topsort.cmx
+ounit_tests/ounit_sexp_tests.cmx : ounit/oUnit.cmx ext/ext_sexp.cmx
 ounit_tests/ounit_tests_main.cmx : ext/resize_array.cmx \
     ounit_tests/ounit_vec_test.cmx ounit_tests/ounit_union_find_tests.cmx \
     ounit_tests/ounit_topsort_tests.cmx ounit_tests/ounit_string_tests.cmx \
-    ounit_tests/ounit_scc_tests.cmx ounit_tests/ounit_path_tests.cmx \
+    ounit_tests/ounit_sexp_tests.cmx ounit_tests/ounit_scc_tests.cmx \
+    ounit_tests/ounit_path_tests.cmx \
     ounit_tests/ounit_ordered_hash_set_tests.cmx \
     ounit_tests/ounit_map_tests.cmx ounit_tests/ounit_list_test.cmx \
     ounit_tests/ounit_json_tests.cmx ounit_tests/ounit_hashtbl_tests.cmx \
@@ -640,9 +644,6 @@ bsb/bsb_main.cmx : ext/string_vec.cmx ext/literals.cmx ext/ext_string.cmx \
 bsb/bsb_ninja.cmx : ext/string_set.cmx ext/string_map.cmx ext/literals.cmx \
     ext/ext_filename.cmx bsb/bsb_config.cmx bsb/bsb_build_util.cmx \
     bsb/bsb_build_ui.cmx common/binary_cache.cmx bsb/bsb_ninja.cmi
-bsb/sexp_eval.cmx : ext/string_hashtbl.cmx bsb/sexp_lexer.cmx \
-    ext/ext_list.cmx
-bsb/sexp_lexer.cmx : bsb/sexp_lexer.cmi
 bsb/bsb_build_ui.cmi : ext/string_set.cmi ext/string_map.cmi \
     ext/ext_file_pp.cmi bsb/bsb_json.cmi common/binary_cache.cmi
 bsb/bsb_build_util.cmi : bsb/bsb_json.cmi
@@ -655,7 +656,6 @@ bsb/bsb_helper_main.cmi :
 bsb/bsb_json.cmi : ext/string_map.cmi
 bsb/bsb_main.cmi :
 bsb/bsb_ninja.cmi : bsb/bsb_default.cmi bsb/bsb_build_ui.cmi
-bsb/sexp_lexer.cmi :
 jscmj_main.cmx : common/js_config.cmx core/js_cmj_format.cmx \
     ext/ext_string.cmx ext/ext_pp.cmx ext/ext_pervasives.cmx \
     ext/ext_array.cmx jscmj_main.cmi

jscomp/bin/all_ounit_tests.d

@@ -71,6 +71,9 @@ bin/all_ounit_tests.ml : ext/int_vec_vec.mli
 bin/all_ounit_tests.ml : ext/ext_scc.ml
 bin/all_ounit_tests.ml : ext/ext_scc.mli
 bin/all_ounit_tests.ml : ounit_tests/ounit_scc_tests.ml
+bin/all_ounit_tests.ml : ext/ext_sexp.ml
+bin/all_ounit_tests.ml : ext/ext_sexp.mli
+bin/all_ounit_tests.ml : ounit_tests/ounit_sexp_tests.ml
 bin/all_ounit_tests.ml : ounit_tests/ounit_string_tests.ml
 bin/all_ounit_tests.ml : ext/ext_topsort.ml
 bin/all_ounit_tests.ml : ext/ext_topsort.mli