serialize can raise

Author: bobzhang

jscomp/others/js_json.ml

@@ -174,7 +174,7 @@ let patch : _ -> _ = [%raw{|function (json) {
 |}]
 
 
-let serialize (type t) (x : t) : string option = [%raw{| function(obj){
+let serializeExn (type t) (x : t) : string option = [%raw{| function(obj){
   return JSON.stringify(obj,function(_,value){
       if(value===undefined){
           return {RE_PRIVATE_NONE : true}

jscomp/others/js_json.mli

@@ -236,9 +236,9 @@ Js.log \@\@ Js.Json.stringifyAny [| "foo"; "bar" |]
 *)
 
 
-
+(** Best-effort serialization, it tries to seralize as 
+  many objects as possible and deserialize it back*) 
 
 val deserializeExn : string -> 'a 
 
-(** Best-effort serialization, it tries to seralize as many objects as possible and deserialize it back*) 
-val serialize : 'a -> string option 
+val serializeExn : 'a -> string option 

jscomp/test/js_json_test.js

@@ -737,7 +737,7 @@ eq("File \"js_json_test.ml\", line 388, characters 5-12", Js_json.decodeNull({})
 eq("File \"js_json_test.ml\", line 390, characters 5-12", Js_json.decodeNull(1.23), undefined);
 
 function id(obj) {
-  var x = Js_json.serialize(obj);
+  var x = Js_json.serializeExn(obj);
   if (x !== undefined) {
     return Js_json.deserializeExn(x);
   }

jscomp/test/js_json_test.ml

@@ -392,7 +392,7 @@ let () =
 
 
 let id (type t ) (obj : t) : t  = 
-    match J.serialize obj with 
+    match J.serializeExn obj with 
     | None -> assert false 
     | Some x -> J.deserializeExn x  
 

lib/es6/js_json.js

@@ -136,7 +136,7 @@ var patch = (function (json) {
   return x[0];
 });
 
-function serialize(x) {
+function serializeExn(x) {
   return (function(obj){
   return JSON.stringify(obj,function(_,value){
       if(value===undefined){
@@ -161,7 +161,7 @@ export {
   decodeBoolean ,
   decodeNull ,
   deserializeExn ,
-  serialize ,
+  serializeExn ,
 
 }
 /* No side effect */

lib/js/js_json.js

@@ -136,7 +136,7 @@ var patch = (function (json) {
   return x[0];
 });
 
-function serialize(x) {
+function serializeExn(x) {
   return (function(obj){
   return JSON.stringify(obj,function(_,value){
       if(value===undefined){
@@ -160,5 +160,5 @@ exports.decodeArray = decodeArray;
 exports.decodeBoolean = decodeBoolean;
 exports.decodeNull = decodeNull;
 exports.deserializeExn = deserializeExn;
-exports.serialize = serialize;
+exports.serializeExn = serializeExn;
 /* No side effect */