From 783eaaa08a9dd03b37cf0c5c35ad2b42d9ba07d6 Mon Sep 17 00:00:00 2001
From: =?UTF-8?q?Mario=20Ba=C5=A1i=C4=87?= <mario@laravelista.hr>
Date: Fri, 5 Dec 2025 23:22:20 +0100
Subject: [PATCH] feat: makes type checking more strict

---
 .helix/config.toml   |  2 ++
 server/src/server.ts | 26 +++++++++++++-------------
 server/src/utils.ts  |  4 +++-
 server/tsconfig.json |  3 +++
 4 files changed, 21 insertions(+), 14 deletions(-)
 create mode 100644 .helix/config.toml

diff --git a/.helix/config.toml b/.helix/config.toml
new file mode 100644
index 000000000..a1ec3e0a6
--- /dev/null
+++ b/.helix/config.toml
@@ -0,0 +1,2 @@
+[editor]
+auto-format = false
diff --git a/server/src/server.ts b/server/src/server.ts
index fccd88916..090bb564b 100644
--- a/server/src/server.ts
+++ b/server/src/server.ts
@@ -1445,19 +1445,19 @@ async function onMessage(msg: p.Message) {
             // TODO: Support range for full, and add delta support
             full: true,
           },
-          inlayHintProvider: config.extensionConfiguration.inlayHints?.enable,
-          codeLensProvider: config.extensionConfiguration.codeLens
-            ? {
-                workDoneProgress: false,
-              }
-            : undefined,
-          signatureHelpProvider: config.extensionConfiguration.signatureHelp
-            ?.enabled
-            ? {
-                triggerCharacters: ["("],
-                retriggerCharacters: ["=", ","],
-              }
-            : undefined,
+          inlayHintProvider:
+            config.extensionConfiguration.inlayHints?.enable || false,
+          ...(config.extensionConfiguration.codeLens && {
+            codeLensProvider: {
+              workDoneProgress: false,
+            },
+          }),
+          ...(config.extensionConfiguration.signatureHelp?.enabled && {
+            signatureHelpProvider: {
+              triggerCharacters: ["("],
+              retriggerCharacters: ["=", ","],
+            },
+          }),
         },
       };
       let response: p.ResponseMessage = {
diff --git a/server/src/utils.ts b/server/src/utils.ts
index ac47a2c58..63ebd19f5 100644
--- a/server/src/utils.ts
+++ b/server/src/utils.ts
@@ -969,7 +969,9 @@ export let parseCompilerLogOutput = async (
       let diagnostic: p.Diagnostic = {
         severity: parsedDiagnostic.severity,
         tags: parsedDiagnostic.tag === undefined ? [] : [parsedDiagnostic.tag],
-        code: parsedDiagnostic.code,
+        ...(parsedDiagnostic.code && {
+          code: parsedDiagnostic.code,
+        }),
         range,
         source: "ReScript",
         message,
diff --git a/server/tsconfig.json b/server/tsconfig.json
index 5dab877e0..b73edf0bf 100644
--- a/server/tsconfig.json
+++ b/server/tsconfig.json
@@ -1,4 +1,5 @@
 {
+  "$schema": "https://json.schemastore.org/tsconfig",
   "compilerOptions": {
     "target": "es2019",
     "lib": ["ES2019"],
@@ -8,6 +9,8 @@
     "strict": true,
     "outDir": "out",
     "rootDir": "src",
+    "strictNullChecks": true,
+    "exactOptionalPropertyTypes": true,
     "esModuleInterop": true
   },
   "include": ["src"],