Emit completable where it is processed.

Author: cristianoc

analysis/src/CompletionBackEnd.ml

@@ -1396,8 +1396,9 @@ let rec completeTypedValue ~full ~prefix ~completionContext ~mode
         ~env;
     ]
 
-let rec processCompletable ~debug ~full ~scope ~env ~pos ~forHover
-    (completable : Completable.t) =
+let rec processCompletable ~debug ~full ~scope ~env ~pos ~forHover completable =
+  if debug then
+    Printf.printf "Completable: %s\n" (Completable.toString completable);
   let package = full.package in
   let rawOpens = Scope.getRawOpens scope in
   let opens = getOpens ~debug ~rawOpens ~package ~env in

analysis/src/Completions.ml

@@ -9,9 +9,6 @@ let getCompletions ~debug ~path ~pos ~currentFile ~forHover =
     with
     | None -> None
     | Some (completable, scope) -> (
-      if debug then
-        Printf.printf "Completable: %s\n"
-          (SharedTypes.Completable.toString completable);
       (* Only perform expensive ast operations if there are completables *)
       match Cmt.loadFullCmtFromPath ~path with
       | None -> None

analysis/tests/src/expected/Completion.res.txt

@@ -1449,6 +1449,7 @@ Ppat_construct T:[362:7->362:8]
 Completable: Cpattern Value[x]=T
 Raw opens: 2 Shadow.B.place holder ... Shadow.A.place holder
 Resolved opens 2 Completion.res Completion.res
+Completable: Cpath Value[T]
 Raw opens: 2 Shadow.B.place holder ... Shadow.A.place holder
 Resolved opens 2 Completion.res Completion.res
 [{

analysis/tests/src/expected/SignatureHelp.res.txt

@@ -3,6 +3,7 @@ posCursor:[16:19] posNoWhite:[16:18] Found expr:[16:11->16:20]
 Pexp_apply ...[16:11->16:19] (...[46:0->16:20])
 posCursor:[16:19] posNoWhite:[16:18] Found expr:[16:11->16:19]
 Pexp_ident someFunc:[16:11->16:19]
+Completable: Cpath Value[someFunc]
 argAtCursor: unlabelled<0>
 extracted params: 
 [(
@@ -22,6 +23,7 @@ posCursor:[19:19] posNoWhite:[19:18] Found expr:[19:11->19:21]
 Pexp_apply ...[19:11->19:19] (...[19:20->19:21])
 posCursor:[19:19] posNoWhite:[19:18] Found expr:[19:11->19:19]
 Pexp_ident someFunc:[19:11->19:19]
+Completable: Cpath Value[someFunc]
 argAtCursor: unlabelled<0>
 extracted params: 
 [(
@@ -41,6 +43,7 @@ posCursor:[22:19] posNoWhite:[22:18] Found expr:[22:11->22:29]
 Pexp_apply ...[22:11->22:19] (...[22:20->22:23], ~two22:26->22:29=...[22:26->22:29])
 posCursor:[22:19] posNoWhite:[22:18] Found expr:[22:11->22:19]
 Pexp_ident someFunc:[22:11->22:19]
+Completable: Cpath Value[someFunc]
 argAtCursor: ~two
 extracted params: 
 [(
@@ -60,6 +63,7 @@ posCursor:[25:19] posNoWhite:[25:18] Found expr:[25:11->25:35]
 Pexp_apply ...[25:11->25:19] (...[25:20->25:23], ~two25:26->25:29=...[25:30->25:35])
 posCursor:[25:19] posNoWhite:[25:18] Found expr:[25:11->25:19]
 Pexp_ident someFunc:[25:11->25:19]
+Completable: Cpath Value[someFunc]
 argAtCursor: ~two
 extracted params: 
 [(
@@ -79,6 +83,7 @@ posCursor:[28:19] posNoWhite:[28:18] Found expr:[28:11->28:42]
 Pexp_apply ...[28:11->28:19] (...[28:20->28:23], ~two28:26->28:29=...[28:30->28:35], ~four28:38->28:42=...[28:38->28:42])
 posCursor:[28:19] posNoWhite:[28:18] Found expr:[28:11->28:19]
 Pexp_ident someFunc:[28:11->28:19]
+Completable: Cpath Value[someFunc]
 argAtCursor: ~four
 extracted params: 
 [(
@@ -98,6 +103,7 @@ posCursor:[31:19] posNoWhite:[31:18] Found expr:[31:11->31:44]
 Pexp_apply ...[31:11->31:19] (...[31:20->31:23], ~two31:26->31:29=...[31:30->31:35], ~four31:38->31:42=...[31:43->31:44])
 posCursor:[31:19] posNoWhite:[31:18] Found expr:[31:11->31:19]
 Pexp_ident someFunc:[31:11->31:19]
+Completable: Cpath Value[someFunc]
 argAtCursor: ~four
 extracted params: 
 [(
@@ -117,6 +123,7 @@ posCursor:[34:20] posNoWhite:[34:19] Found expr:[34:11->34:21]
 Pexp_apply ...[34:11->34:20] (...[46:0->34:21])
 posCursor:[34:20] posNoWhite:[34:19] Found expr:[34:11->34:20]
 Pexp_ident otherFunc:[34:11->34:20]
+Completable: Cpath Value[otherFunc]
 argAtCursor: unlabelled<0>
 extracted params: 
 [(string, int, float]
@@ -134,6 +141,7 @@ posCursor:[37:20] posNoWhite:[37:19] Found expr:[37:11->37:26]
 Pexp_apply ...[37:11->37:20] (...[37:21->37:26])
 posCursor:[37:20] posNoWhite:[37:19] Found expr:[37:11->37:20]
 Pexp_ident otherFunc:[37:11->37:20]
+Completable: Cpath Value[otherFunc]
 argAtCursor: unlabelled<0>
 extracted params: 
 [(string, int, float]
@@ -151,6 +159,7 @@ posCursor:[40:20] posNoWhite:[40:19] Found expr:[40:11->40:39]
 Pexp_apply ...[40:11->40:20] (...[40:21->40:26], ...[40:28->40:31], ...[40:33->40:38])
 posCursor:[40:20] posNoWhite:[40:19] Found expr:[40:11->40:20]
 Pexp_ident otherFunc:[40:11->40:20]
+Completable: Cpath Value[otherFunc]
 argAtCursor: unlabelled<2>
 extracted params: 
 [(string, int, float]
@@ -168,6 +177,7 @@ posCursor:[43:29] posNoWhite:[43:28] Found expr:[43:11->43:34]
 Pexp_apply ...[43:11->43:29] (~age43:31->43:34=...[43:31->43:34])
 posCursor:[43:29] posNoWhite:[43:28] Found expr:[43:11->43:29]
 Pexp_ident Completion.Lib.foo:[43:11->43:29]
+Completable: Cpath Value[Completion, Lib, foo]
 argAtCursor: ~age
 extracted params: 
 [(~age: int, ~name: string]
@@ -185,6 +195,7 @@ posCursor:[50:23] posNoWhite:[50:22] Found expr:[50:11->50:24]
 Pexp_apply ...[50:11->50:23] (...[56:0->50:24])
 posCursor:[50:23] posNoWhite:[50:22] Found expr:[50:11->50:23]
 Pexp_ident iAmSoSpecial:[50:11->50:23]
+Completable: Cpath Value[iAmSoSpecial]
 argAtCursor: unlabelled<0>
 extracted params: 
 [string]
@@ -203,6 +214,7 @@ posCursor:[53:29] posNoWhite:[53:28] Found expr:[53:20->53:31]
 Pexp_apply ...[53:20->53:29] (...[53:30->53:31])
 posCursor:[53:29] posNoWhite:[53:28] Found expr:[53:20->53:29]
 Pexp_ident otherFunc:[53:20->53:29]
+Completable: Cpath Value[otherFunc]
 argAtCursor: unlabelled<1>
 extracted params: 
 [(string, int, float]
@@ -220,6 +232,7 @@ posCursor:[62:13] posNoWhite:[62:12] Found expr:[62:11->62:19]
 Pexp_apply ...[62:11->62:13] (...[62:14->62:16])
 posCursor:[62:13] posNoWhite:[62:12] Found expr:[62:11->62:13]
 Pexp_ident fn:[62:11->62:13]
+Completable: Cpath Value[fn]
 argAtCursor: unlabelled<1>
 extracted params: 
 [(int, string, int]
@@ -237,6 +250,7 @@ posCursor:[65:13] posNoWhite:[65:12] Found expr:[65:11->65:25]
 Pexp_apply ...[65:11->65:13] (...[65:14->65:16], ...[65:20->65:24])
 posCursor:[65:13] posNoWhite:[65:12] Found expr:[65:11->65:13]
 Pexp_ident fn:[65:11->65:13]
+Completable: Cpath Value[fn]
 argAtCursor: unlabelled<1>
 extracted params: 
 [(int, string, int]
@@ -254,6 +268,7 @@ posCursor:[68:13] posNoWhite:[68:12] Found expr:[68:11->68:28]
 Pexp_apply ...[68:11->68:13] (...[68:14->68:16], ...[68:18->68:25])
 posCursor:[68:13] posNoWhite:[68:12] Found expr:[68:11->68:13]
 Pexp_ident fn:[68:11->68:13]
+Completable: Cpath Value[fn]
 argAtCursor: unlabelled<2>
 extracted params: 
 [(int, string, int]
@@ -273,6 +288,7 @@ posCursor:[71:28] posNoWhite:[71:27] Found expr:[71:16->71:30]
 Pexp_apply ...[71:16->71:28] (...[71:29->71:30])
 posCursor:[71:28] posNoWhite:[71:27] Found expr:[71:16->71:28]
 Pexp_ident iAmSoSpecial:[71:16->71:28]
+Completable: Cpath Value[iAmSoSpecial]
 argAtCursor: unlabelled<0>
 extracted params: 
 [string]
@@ -294,6 +310,7 @@ posCursor:[74:39] posNoWhite:[74:38] Found expr:[74:31->74:41]
 Pexp_apply ...[74:31->74:39] (...[74:40->74:41])
 posCursor:[74:39] posNoWhite:[74:38] Found expr:[74:31->74:39]
 Pexp_ident someFunc:[74:31->74:39]
+Completable: Cpath Value[someFunc]
 argAtCursor: unlabelled<0>
 extracted params: 
 [(