Windows fixes (#71)

* Add windows fixes for files

* Remove dependencies not in original repo

* Change const to let again

* Remove amusing letants

* Remove space

* Remove the two first spaces since it is trimmed

* Refactor separatefileandlocation function

* Fix spacing

* Add one space

* Move findlocationseparator into other function

* Reformatted some code

* Revert package.json

Reverting package.json as it is a unnecessary change

* Update from comments

* Revert clien package-lock.json

* Use vscode uri utils for file scheme

* Add semicolons

* Add two semicolons

* Remove trim call as to follow repos best practices

* Move to lockfile package 2

This is a reversion

* Include spaces in colon separator search

* We need to remove the spaces for URI.file to work

Co-authored-by: mewhhaha <kopatheonlyone@hotmail.com>

Author: John Pangalos

package-lock.json

@@ -13,7 +13,8 @@
 	},
 	"dependencies": {
 		"vscode-languageserver": "^6.1.1",
-		"vscode-languageserver-textdocument": "^1.0.1"
+		"vscode-languageserver-textdocument": "^1.0.1",
+		"vscode-uri": "^3.0.2"
 	},
 	"scripts": {}
 }

server/package-lock.json

@@ -6,6 +6,7 @@ import * as path from "path";
 import * as t from "vscode-languageserver-types";
 import fs from "fs";
 import * as os from "os";
+import { URI } from 'vscode-uri';
 
 let tempFilePrefix = "rescript_format_file_" + process.pid + "_";
 let tempFileId = 0;
@@ -105,10 +106,15 @@ export let runBsbWatcherUsingValidBsbPath = (
 	bsbPath: p.DocumentUri,
 	projectRootPath: p.DocumentUri
 ) => {
-	let process = childProcess.execFile(bsbPath, ["-w"], {
-		cwd: projectRootPath,
-	});
-	return process;
+	if (process.platform === "win32") {
+		return childProcess.exec(`${bsbPath}.cmd -w`, {
+			cwd: projectRootPath,
+		});
+	} else {
+		return childProcess.execFile(bsbPath, ["-w"], {
+			cwd: projectRootPath,
+		})
+	}
 	// try {
 	// 	let result = childProcess.execFileSync(bsbPath, [], { stdio: 'pipe', cwd: projectRootPath })
 	// 	return {
@@ -154,6 +160,25 @@ export let parseDiagnosticLocation = (location: string): Range => {
 	}
 };
 
+let findLocationSeparator = (fileAndLocation: string) => {
+	// Exclude the two first letters in windows paths to avoid the first colon in eg "c:\\.."		
+	if (process.platform === "win32") {
+		return fileAndLocation.indexOf(":", 2);
+	} else {
+		return fileAndLocation.indexOf(":");
+	}
+};
+
+let separateFileAndLocation = (fileAndLocation: string): [string, string] => {
+	let locationSeparator = findLocationSeparator(fileAndLocation);
+	let file = fileAndLocation.slice(0, locationSeparator);
+	let location = fileAndLocation.slice(locationSeparator + 1);
+
+	return [URI.file(file).toString(), location];
+};
+
+
+
 type filesDiagnostics = {
 	[key: string]: p.Diagnostic[];
 };
@@ -273,10 +298,10 @@ export let parseCompilerLogOutput = (
 
 	let result: filesDiagnostics = {};
 	parsedDiagnostics.forEach((parsedDiagnostic) => {
-		let [fileAndLocation, ...diagnosticMessage] = parsedDiagnostic.content;
-		let locationSeparator = fileAndLocation.indexOf(":");
-		let file = fileAndLocation.substring(2, locationSeparator);
-		let location = fileAndLocation.substring(locationSeparator + 1);
+		let [fileAndLocationLine, ...diagnosticMessage] = parsedDiagnostic.content;
+
+		let [file, location] = separateFileAndLocation(fileAndLocationLine.slice(2));
+
 		if (result[file] == null) {
 			result[file] = [];
 		}