-
Notifications
You must be signed in to change notification settings - Fork 1.2k
improve toaster #6543
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
improve toaster #6543
Conversation
✅ Deploy Preview for reliable-cocada-166884 ready!
To edit notification comments on pull requests, go to your Netlify project configuration. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks almost fine to me. @ninja-fire Can you check if we can make the toaster color visibility more user friendly?
63a53a2 to
b1e4955
Compare
6783d80 to
48432e2
Compare
Aniket-Engg
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
| timeOutId, | ||
| message: shortTooltipText | ||
| // Show toast using Sonner | ||
| const duration = props.timeOut || 120000 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
default value should be 1-2 seconds only
b616ab2 to
03172bb
Compare
|
View your CI Pipeline Execution ↗ for commit 7fffa2f
☁️ Nx Cloud last updated this comment at |
|
✅ E2E tests passed (workflow: web) Last run: Mon, Dec 8, 2025, 04:44 PM UTC All tests are now passing! Previous failures have been resolved. |
d2c01cc to
a6c7fe4
Compare
db20e22 to
6c4ff77
Compare
6c4ff77 to
b056bc7
Compare
| }) | ||
| }, | ||
|
|
||
| /* |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
why have you commented this e2e?
Removed commented-out test case for loading compiler from URL.


No description provided.