Skip to content

Conversation

@yann300
Copy link
Contributor

@yann300 yann300 commented Nov 12, 2025

No description provided.

@yann300 yann300 requested a review from Aniket-Engg November 12, 2025 11:45
@netlify
Copy link

netlify bot commented Nov 12, 2025

Deploy Preview for reliable-cocada-166884 ready!

Name Link
🔨 Latest commit 7fffa2f
🔍 Latest deploy log https://app.netlify.com/projects/reliable-cocada-166884/deploys/6936f72504e62300085336ad
😎 Deploy Preview https://deploy-preview-6543--reliable-cocada-166884.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify project configuration.

@yann300 yann300 added the ready-to-review PR ready to review label Nov 12, 2025
@Aniket-Engg
Copy link
Collaborator

Screenshot 2025-11-24 at 2 02 45 PM

Position of toaster should be improved

Copy link
Collaborator

@Aniket-Engg Aniket-Engg left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks almost fine to me. @ninja-fire Can you check if we can make the toaster color visibility more user friendly?

Copy link
Collaborator

@Aniket-Engg Aniket-Engg left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Screenshot 2025-11-27 at 5 50 45 PM

Please fix the UI for cancel icon.

I think we can keep the text color to white and update background color as per the toaster type.

timeOutId,
message: shortTooltipText
// Show toast using Sonner
const duration = props.timeOut || 120000
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

default value should be 1-2 seconds only

@nx-cloud
Copy link

nx-cloud bot commented Dec 4, 2025

View your CI Pipeline Execution ↗ for commit 7fffa2f

Command Status Duration Result
nx build plugin_api --configuration=production ... ✅ Succeeded <1s View ↗
nx lint vyper ✅ Succeeded <1s View ↗
nx lint remixd ✅ Succeeded <1s View ↗
nx lint solhint ✅ Succeeded <1s View ↗
nx lint doc-gen ✅ Succeeded <1s View ↗
nx lint remix-ui ✅ Succeeded <1s View ↗
nx lint learneth ✅ Succeeded <1s View ↗
nx lint debugger ✅ Succeeded <1s View ↗
Additional runs (24) ✅ Succeeded ... View ↗

☁️ Nx Cloud last updated this comment at 2025-12-08 16:12:08 UTC

@ci-pr-comment
Copy link

ci-pr-comment bot commented Dec 4, 2025

✅ E2E tests passed (workflow: web)

Last run: Mon, Dec 8, 2025, 04:44 PM UTC

All tests are now passing! Previous failures have been resolved.

@yann300 yann300 force-pushed the improve_toaster branch 4 times, most recently from d2c01cc to a6c7fe4 Compare December 8, 2025 13:02
@yann300 yann300 force-pushed the improve_toaster branch 2 times, most recently from db20e22 to 6c4ff77 Compare December 8, 2025 13:37
})
},

/*
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

why have you commented this e2e?

Removed commented-out test case for loading compiler from URL.
@Aniket-Engg Aniket-Engg enabled auto-merge December 8, 2025 16:11
@Aniket-Engg Aniket-Engg merged commit 2812556 into master Dec 8, 2025
34 checks passed
@Aniket-Engg Aniket-Engg deleted the improve_toaster branch December 8, 2025 16:21
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

ready-to-review PR ready to review

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants