remove clippy warnings

Author: calebbourg

cross/secrets/secrets.rs

@@ -3,5 +3,5 @@
 //              all example applications
 //
 
-const SSID: &str = "Zion";
-const PASSPHRASE: &str = "Diesel12103465";
+const SSID: &str = "";
+const PASSPHRASE: &str = "";

esp32-wroom-rp/src/network.rs

@@ -16,27 +16,43 @@ pub(crate) type Socket = u8;
 #[repr(u8)]
 #[derive(PartialEq, Eq, Copy, Clone, Debug)]
 pub enum TransportMode {
+    /// TCP mode
     Tcp = 0,
+    /// UDP mode
     Udp = 1,
+    /// TLS mode
     Tls = 2,
+    /// UDP multicast mode
     UdpMulticast = 3,
+    /// TLS BearSSL mode
     TlsBearSsl = 4,
 }
 
 /// Defines all possible TCP connection states for a client or server instance.
 #[repr(u8)]
 #[derive(PartialEq, PartialOrd, Debug)]
 pub enum ConnectionState {
+    /// Closed
     Closed = 0,
+    /// Listening
     Listening = 1,
+    /// SynSent
     SynSent = 2,
+    /// SynReceived
     SynReceived = 3,
+    /// Established
     Established = 4,
+    /// FinWait1
     FinWait1 = 5,
+    /// Finwait2
     FinWait2 = 6,
+    /// CloseWait
     CloseWait = 7,
+    /// Closing
     Closing = 8,
+    /// LastAck
     LastAck = 9,
+    /// TimeWait
     TimeWait = 10,
 }
 

esp32-wroom-rp/src/protocol.rs

@@ -128,7 +128,7 @@ impl NinaParam for NinaAbstractParam {
     }
 
     fn length(&self) -> u16 {
-        self.length as u16
+        self.length
     }
 
     fn length_size(&self) -> u8 {
@@ -220,7 +220,7 @@ impl NinaConcreteParam for NinaByteParam {
     }
 
     fn length_as_bytes(&self) -> Self::LengthAsBytes {
-        [self.length as u8]
+        [self.length]
     }
 }
 
@@ -253,7 +253,7 @@ impl NinaConcreteParam for NinaWordParam {
     }
 
     fn length_as_bytes(&self) -> Self::LengthAsBytes {
-        [self.length as u8]
+        [self.length]
     }
 }
 
@@ -286,7 +286,7 @@ impl NinaConcreteParam for NinaSmallArrayParam {
     }
 
     fn length_as_bytes(&self) -> Self::LengthAsBytes {
-        [self.length as u8]
+        [self.length]
     }
 }
 

esp32-wroom-rp/src/spi.rs

@@ -245,7 +245,7 @@ where
             operation.params.iter().for_each(|param| {
                 self.send_param(param).ok();
 
-                total_params_length += param.length() as u16;
+                total_params_length += param.length();
                 total_params_length_size += param.length_size() as u16;
             });
 
@@ -341,7 +341,7 @@ where
     fn get_byte(&mut self) -> Result<u8, Infallible> {
         let word_out = &mut [ControlByte::Dummy as u8];
         let word = self.bus.borrow_mut().transfer(word_out).ok().unwrap();
-        Ok(word[0] as u8)
+        Ok(word[0])
     }
 
     fn wait_for_byte(&mut self, wait_byte: u8) -> Result<bool, Error> {
@@ -369,18 +369,16 @@ where
 
     fn send_param<P: NinaParam>(&mut self, param: &P) -> Result<(), Infallible> {
         self.send_param_length(param)?;
-        let data_length = param.length() as usize;
-        let bytes = param.data();
-        for i in 0..data_length {
-            self.bus.borrow_mut().transfer(&mut [bytes[i]]).ok();
+        for byte in param.data().iter() {
+            self.bus.borrow_mut().transfer(&mut [*byte]).ok();
         }
         Ok(())
     }
 
     fn send_param_length<P: NinaParam>(&mut self, param: &P) -> Result<(), Infallible> {
         let bytes = param.length_as_bytes();
-        for i in 0..param.length_size() as usize {
-            self.bus.borrow_mut().transfer(&mut [bytes[i]]).ok();
+        for byte in bytes.iter().take(param.length_size() as usize) {
+            self.bus.borrow_mut().transfer(&mut [*byte]).ok();
         }
         Ok(())
     }

esp32-wroom-rp/src/tcp_client.rs

@@ -12,8 +12,6 @@ use embedded_hal::blocking::spi::Transfer;
 
 use heapless::String;
 
-// TODO: find a good max length
-const MAX_DATA_LENGTH: usize = 512;
 const MAX_HOSTNAME_LENGTH: usize = 255;
 
 /// Connect trait that allows for a `TcpClient` instance to connect to a remote
@@ -131,11 +129,13 @@ where
     }
 
     // TODO: Make this non-public
+    /// Requests a Socket
     pub fn get_socket(&mut self) -> Result<Socket, Error> {
         self.protocol_handler.get_socket()
     }
 
     // TODO: Make this non-public
+    /// Returns `Socket` reference set by calling `get_socket()`
     pub fn socket(&self) -> Socket {
         self.socket.unwrap()
     }

esp32-wroom-rp/src/wifi.rs

@@ -99,7 +99,7 @@ pub struct Wifi<B, C> {
     pub(crate) protocol_handler: RefCell<NinaProtocolHandler<B, C>>,
 }
 
-impl<'a, S, C> Wifi<S, C>
+impl<S, C> Wifi<S, C>
 where
     S: Transfer<u8>,
     C: EspControlInterface,