🐛 Bug Report: Rate limit mismatch

[mtpakergh]

docker logs -f redlib
ERROR redlib::client > Got an invalid response from reddit expected value at line 1 column 1. Status code: 403 Forbidden
Rate limit check failed: Failed to parse page JSON data: expected value at line 1 column 1 | /r/reddit/hot.json?&raw_json=1
This may cause issues with the rate limit.
Please report this error with the above information.
https://github.com/redlib-org/redlib/issues/new?assignees=sigaloid&labels=bug&title=%F0%9F%90%9B+Bug+Report%3A+Rate+limit+mismatch
Starting Redlib...
Running Redlib v0.36.0 on [::]:8080!
ERROR redlib::client > Got an invalid response from reddit expected value at line 1 column 1. Status code: 403 Forbidden
ERROR redlib::utils > Error page rendered: Failed to parse page JSON data: expected value at line 1 column 1
ERROR redlib::client > Got an invalid response from reddit expected value at line 1 column 1. Status code: 403 Forbidden
Rate limit check failed: Failed to parse page JSON data: expected value at line 1 column 1 | /r/reddit/hot.json?&raw_json=1
This may cause issues with the rate limit.
Starting Redlib...
Please report this error with the above information.

[gergo-salyi]

I could work around this on a localhost instance on trunk (2dc6b5f) by patching src/oauth.rs to force use the GenericWebAuth OAuth backend instead of the default MobileSpoofAuth OAuth backend.

$ git diff
diff --git a/src/oauth.rs b/src/oauth.rs
index 0b4f7fe..fff7dc3 100644
--- a/src/oauth.rs
+++ b/src/oauth.rs
@@ -75,7 +75,7 @@ impl Oauth {
        pub(crate) async fn new() -> Self {
                // Try MobileSpoofAuth first, then fall back to GenericWebAuth
                let mut failure_count = 0;
-               let mut backend = OauthBackendImpl::MobileSpoof(MobileSpoofAuth::new());
+               let mut backend = OauthBackendImpl::GenericWeb(GenericWebAuth::new());

                loop {
                        let attempt = Self::new_with_timeout_with_backend(backend.clone()).await;

This is just an emergency hack and rate limits might by affected so I don't know if doing this is possible for larger instances.

Anyway this may indicate that the currently obtained mobil reddit credentials are no longer good. Someone who unlike me understands how they work should take a look at them and find a proper fix. (And for the long term maybe add a command line switch or env var to force select a given OAuth backend).

[dasbootbee]

Why is this affecting my private instance? I can click on "Visit Random Instance" and find public instances working just fine.

[magostinelli]

Why is this affecting my private instance? I can click on "Visit Random Instance" and find public instances working just fine.

Watch on PR there are fixed version ready to use.

[esturniolo]

Sorry but which is the branch used for this?
It's already merged?

[dasbootbee]

I'm using docker. When is that PR going to be merged for a new release tag?

[magostinelli]

Take a look here:
https://github.com/magostinelli/redlib

I modified the Dockerfile, so you can clone the repository and you can build the version with docker build .

[jeeneo]

ive forked and created a small patch in the meantime for oauth backend switching if anyone needs it, https://github.com/jeeneo/redlib, removed, broken anyway lol

[Morethanevil]

ive forked and created a small patch in the meantime for oauth backend switching if anyone needs it, https://github.com/jeeneo/redlib

Tried your fork, but still the same issue

[jeeneo]

ive forked and created a small patch in the meantime for oauth backend switching if anyone needs it, removed

Tried your fork, but still the same issue

did you set the env var REDLIB_OAUTH_BACKEND=genericweb? i updated the env var example to explain, maybe i should've updated the readme, it defaults to mobilespoof as per the original code

if youre running the binary you can also run with ./redlib --oauth-backend genericweb or with environment as REDLIB_OAUTH_BACKEND=genericweb ./redlib

edit: although i could probably to patch it to have better error checking for mobilespoof and auto change to web

[Morethanevil]

ive forked and created a small patch in the meantime for oauth backend switching if anyone needs it, https://github.com/jeeneo/redlib

Tried your fork, but still the same issue

did you set the env var REDLIB_OAUTH_BACKEND=genericweb? i updated the env var example to explain, maybe i should've updated the readme, it defaults to mobilespoof as per the original code

if youre running the binary you can also run with ./redlib --oauth-backend genericweb or with environment as REDLIB_OAUTH_BACKEND=genericweb ./redlib

edit: although i could probably to patch it to have better error checking for mobilespoof and auto change to web

Thanks! REDLIB_OAUTH_BACKEND=genericweb did the trick :)

Edit after a few hours: I constantly need to restart Redlib or the error reappears.

[jeeneo]

Edit after a few hours: I constantly need to restart Redlib or the error reappears.

yeah i had this happen when testing today, im not a rust dev nor knowledgeable with how reddit is designed, so i can't help with that, im just a script kiddie here lol. maybe there will be someone who knows how to add a real fix. apologies ;-;

[Sparronator9999]

I haven't had this error yet, but I am the only one that uses my private instance, and I don't use it very often.

[esturniolo]

I added this env value (REDLIB_OAUTH_BACKEND=genericweb) to my compose and nothing changes.
I've the same results

redlib  |  ERROR redlib::client > Got an invalid response from reddit expected value at line 1 column 1. Status code: 403 Forbidden
redlib  | Rate limit check failed: Failed to parse page JSON data: expected value at line 1 column 1 | /r/reddit/hot.json?&raw_json=1

All of this with the latest image.