Update runner functionality with unix socket support and UI improvements

Author: fcostaoliveira

.github/workflows/validate-spec-fields.yml

@@ -8,7 +8,7 @@ on:
 jobs:
   pytest:
     name: Validate SPEC fields
-    runs-on: ubuntu-latest
+    runs-on: ubuntu-22.04
     env:
       ACTIONS_ALLOW_UNSECURE_COMMANDS: true
     steps:

redis_benchmarks_specification/__common__/runner.py

@@ -106,11 +106,16 @@ def extract_testsuites(args):
     testsuite_spec_files = get_benchmark_specs(
         testsuites_folder, args.test, args.tests_regexp
     )
+    testsuite_spec_files.sort()
     logging.info(
         "There are a total of {} test-suites in folder {}".format(
             len(testsuite_spec_files), testsuites_folder
         )
     )
+    if len(testsuite_spec_files) < 11:
+        for test in testsuite_spec_files:
+            logging.info(f"Test {test}")
+
     return testsuite_spec_files
 
 

redis_benchmarks_specification/__compare__/compare.py

@@ -874,11 +874,12 @@ def compute_regression_table(
     len_no_datapoints = len(no_datapoints_list)
     if len_no_datapoints > 0:
         table_output += f"\n  WARNING: There were {len_no_datapoints} benchmarks with NO datapoints for both baseline and comparison.\n\n"
+        table_output += "<details>\n  <summary>NO datapoints for both baseline and comparison:</summary>\n\n"
         no_datapoints_test_names_str = "|".join([l for l in no_datapoints_list])
-
         table_output += (
             f"  NO DATAPOINTS test regexp names: {no_datapoints_test_names_str}\n\n"
         )
+        table_output += "\n</details>\n"
 
     return (
         detected_regressions,

redis_benchmarks_specification/__runner__/args.py

@@ -214,4 +214,9 @@ def create_client_runner_args(project_name):
         action="store_true",
         help="Run client in cluster mode.",
     )
+    parser.add_argument(
+        "--unix-socket",
+        default="",
+        help="UNIX Domain socket name",
+    )
     return parser

redis_benchmarks_specification/__runner__/runner.py

@@ -220,17 +220,26 @@ def prepare_memtier_benchmark_parameters(
     resp_version=None,
     override_memtier_test_time=0,
     override_test_runs=1,
+    unix_socket="",
 ):
     arbitrary_command = False
     benchmark_command = [
         full_benchmark_path,
-        "--port",
-        f"{port}",
-        "--server",
-        f"{server}",
         "--json-out-file",
         local_benchmark_output_filename,
     ]
+    if unix_socket != "":
+        benchmark_command.extend(["--unix-socket", unix_socket])
+        logging.info(f"Using UNIX SOCKET to connect {unix_socket}")
+    else:
+        benchmark_command.extend(
+            [
+                "--port",
+                f"{port}",
+                "--server",
+                f"{server}",
+            ]
+        )
     if password is not None:
         benchmark_command.extend(["--authenticate", password])
     if tls_enabled:
@@ -430,6 +439,7 @@ def delete_temporary_files(
 
                     port = args.db_server_port
                     host = args.db_server_host
+                    unix_socket = args.unix_socket
                     password = args.db_server_password
                     oss_cluster_api_enabled = args.cluster_mode
                     ssl_cert_reqs = "required"
@@ -606,7 +616,7 @@ def delete_temporary_files(
                                 )
                                 continue
                         if "preload_tool" in benchmark_config["dbconfig"]:
-                            if args.skip_tests_with_preload_via_tool is False:
+                            if args.skip_tests_with_preload_via_tool is True:
                                 logging.warning(
                                     "Skipping test {} giving it implies dataset preload via tool".format(
                                         test_name
@@ -648,6 +658,7 @@ def delete_temporary_files(
                                 args.benchmark_local_install,
                                 password,
                                 oss_cluster_api_enabled,
+                                unix_socket,
                             )
                             if res is False:
                                 logging.warning(
@@ -748,6 +759,7 @@ def delete_temporary_files(
                             resp_version,
                             override_memtier_test_time,
                             override_test_runs,
+                            unix_socket,
                         )
 
                     if (
@@ -1151,6 +1163,7 @@ def data_prepopulation_step(
     benchmark_local_install=False,
     password=None,
     oss_cluster_api_enabled=False,
+    unix_socket="",
 ):
     result = True
     # setup the benchmark
@@ -1193,6 +1206,8 @@ def data_prepopulation_step(
             tls_cacert,
             resp_version,
             override_memtier_test_time_preload,
+            1,
+            unix_socket,
         )
         if arbitrary_command is True and oss_cluster_api_enabled:
             logging.warning(