Commit 345ae39
committed
Fix critical bugs in pubsub-sub-bench integration
Bug Fixes:
1. Fixed UnboundLocalError: 'is_multiple_clients' referenced before assignment
- Removed duplicate/misplaced code block that used is_multiple_clients before definition
- Ensured proper code flow in process_self_contained_coordinator_stream()
2. Fixed TypeError: argument of type 'NoneType' is not iterable
- Added null check in delete_temporary_files() for benchmark_tool_global
- Changed: if 'redis-benchmark' in benchmark_tool_global
- To: if benchmark_tool_global and 'redis-benchmark' in benchmark_tool_global
Testing:
- All 5 pubsub-sub-bench tests continue to pass
- Successfully tested mixed workload execution:
* memtier_benchmark doing PUBLISH commands
* pubsub-sub-bench doing SUBSCRIBE commands
* Both tools running simultaneously with proper parameter preparation
The runner now correctly handles mixed pub/sub workloads without crashes.1 parent 8d7cb2d commit 345ae39
File tree
3 files changed
+2
-99
lines changed- redis_benchmarks_specification
- __runner__
- test-suites
3 files changed
+2
-99
lines changed| Original file line number | Diff line number | Diff line change | |
|---|---|---|---|
| |||
641 | 641 | | |
642 | 642 | | |
643 | 643 | | |
644 | | - | |
| 644 | + | |
645 | 645 | | |
646 | 646 | | |
647 | 647 | | |
| |||
988 | 988 | | |
989 | 989 | | |
990 | 990 | | |
991 | | - | |
992 | | - | |
993 | | - | |
994 | | - | |
995 | | - | |
996 | | - | |
997 | | - | |
998 | | - | |
999 | | - | |
1000 | | - | |
1001 | | - | |
1002 | | - | |
1003 | | - | |
1004 | | - | |
1005 | | - | |
1006 | | - | |
1007 | | - | |
1008 | | - | |
1009 | | - | |
1010 | | - | |
1011 | | - | |
1012 | | - | |
1013 | | - | |
1014 | | - | |
1015 | | - | |
1016 | | - | |
1017 | | - | |
1018 | | - | |
1019 | | - | |
1020 | | - | |
1021 | | - | |
1022 | | - | |
1023 | | - | |
1024 | | - | |
1025 | | - | |
1026 | | - | |
1027 | | - | |
1028 | | - | |
1029 | | - | |
1030 | | - | |
1031 | | - | |
1032 | | - | |
1033 | | - | |
1034 | | - | |
1035 | | - | |
1036 | | - | |
1037 | | - | |
1038 | | - | |
1039 | | - | |
1040 | | - | |
1041 | | - | |
1042 | | - | |
1043 | | - | |
1044 | | - | |
1045 | | - | |
1046 | | - | |
1047 | | - | |
1048 | | - | |
1049 | | - | |
1050 | | - | |
1051 | | - | |
1052 | | - | |
1053 | | - | |
1054 | | - | |
1055 | | - | |
1056 | | - | |
1057 | | - | |
1058 | | - | |
1059 | | - | |
1060 | | - | |
1061 | 991 | | |
1062 | 992 | | |
1063 | 993 | | |
| |||
| Original file line number | Diff line number | Diff line change | |
|---|---|---|---|
| |||
1 | 1 | | |
2 | | - | |
| 2 | + | |
3 | 3 | | |
4 | 4 | | |
5 | 5 | | |
| |||
Lines changed: 0 additions & 27 deletions
This file was deleted.
0 commit comments