Incorporate review feedback

Author: abrookins

redis_sre_agent/api/app.py

@@ -36,7 +36,7 @@
 LOG_DATE_FORMAT = "%H:%M:%S"
 
 logging.basicConfig(
-    level=logging.__dict__[settings.log_level.upper()],
+    level=getattr(logging, settings.log_level.upper(), logging.INFO),
     format=LOG_FORMAT,
     datefmt=LOG_DATE_FORMAT,
 )

redis_sre_agent/cli/main.py

@@ -36,7 +36,7 @@ def get_command(self, ctx, name):
             return None
         module_path, attr = target.split(":", 1)
         mod = importlib.import_module(module_path)
-        return mod.__dict__[attr]
+        return getattr(mod, attr)
 
 
 @click.command(cls=LazyGroup)

redis_sre_agent/tools/manager.py

@@ -224,7 +224,10 @@ def _get_provider_class(cls, provider_path: str) -> type:
         if provider_path not in cls._provider_class_cache:
             module_path, class_name = provider_path.rsplit(".", 1)
             module = __import__(module_path, fromlist=[class_name])
-            cls._provider_class_cache[provider_path] = module.__dict__[class_name]
+            provider_class = getattr(module, class_name, None)
+            if not provider_class:
+                logger.warning(f"Failed to load tool provider class: {provider_path}")
+            cls._provider_class_cache[provider_path] = provider_class
         return cls._provider_class_cache[provider_path]
 
     async def __aexit__(self, *args) -> None:

redis_sre_agent/tools/models.py

@@ -3,9 +3,6 @@
 
 from pydantic import BaseModel, ConfigDict, Field
 
-if TYPE_CHECKING:
-    from redis_sre_agent.tools.models import ToolDefinition
-
 
 class ToolCapability(Enum):
     """Capabilities that tools can provide."""

redis_sre_agent/tools/protocols.py

@@ -4,7 +4,7 @@
 data classes, and optional Protocols that describe the minimal contracts
 HostTelemetry and other orchestrators can program against.
 """
-
+import logging
 from abc import ABC, abstractmethod
 from typing import TYPE_CHECKING, Any, Dict, List, Optional, Protocol, runtime_checkable
 
@@ -18,6 +18,9 @@
     from .manager import ToolManager
 
 
+logger = logging.getLogger(__name__)
+
+
 # --------------------------- Optional provider Protocols ---------------------------
 # These describe the minimal contracts higher-level orchestrators can rely on
 # without referencing concrete implementations (e.g., Prometheus/Loki).
@@ -395,11 +398,12 @@ def get_status_update(self, tool_name: str, args: Dict[str, Any]) -> Optional[st
         try:
             op = self.resolve_operation(tool_name, args)
             if not op:
+                logger.warning(f"get_status_update failed to resolve operation for {tool_name}")
                 return None
             method = self.__dict__.get(op) or type(self).__dict__.get(op)
             if not method:
                 return None
-            template = method._status_update_template if method else None
+            template = getattr(method, "_status_update_template", None)
             if not template:
                 return None
             try: