Handle /page/ redirects for subprojects #12627
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Documentation build overview
Show files changed (6 files in total): 📝 6 modified | ➕ 0 added | ➖ 0 deleted
|
Documentation build overview
Show files changed (20 files in total): 📝 17 modified | ➕ 0 added | ➖ 3 deleted
|
humitos
reviewed
Dec 9, 2025
Comment on lines
+98
to
+102
| def test_page_redirect_on_subproject_alias(self): | ||
| r = self.client.get( | ||
| "/projects/this-is-an-alias/page/test.html", | ||
| headers={"host": "project.dev.readthedocs.io"}, | ||
| ) |
Member
There was a problem hiding this comment.
We should probably add a test case for a project with a custom /projects/ prefix in the URL as well.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
/projects/<subproject>/page/redirectsTesting
DJANGO_SETTINGS_MODULE=readthedocs.settings.proxito.test uv run pytest readthedocs/proxito/tests/test_old_redirects.py::InternalRedirectTests::test_page_redirect_on_subproject -vv -suv run ruff check readthedocs/proxito/views/serve.py readthedocs/proxito/tests/test_old_redirects.pyCodex Task