From bbea460e62509308d8881a4596617c05d31de3bf Mon Sep 17 00:00:00 2001
From: Spencer McIntyre <zeroSteiner@gmail.com>
Date: Tue, 6 May 2025 11:22:52 -0400
Subject: [PATCH 1/2] Update the test matrix for GitHub

---
 .github/workflows/verify.yml | 4 +++-
 1 file changed, 3 insertions(+), 1 deletion(-)

diff --git a/.github/workflows/verify.yml b/.github/workflows/verify.yml
index dded6cc87..c210284c6 100644
--- a/.github/workflows/verify.yml
+++ b/.github/workflows/verify.yml
@@ -37,8 +37,10 @@ jobs:
           - '3.0'
           - '3.1'
           - '3.2'
+          - '3.3'
+          - '3.4'
         os:
-          - ubuntu-20.04
+          - ubuntu-22.04
           - ubuntu-latest
         exclude:
           - { os: ubuntu-latest, ruby: '2.7' }

From 721137ba7df89312276018cdce9211bb2e6b6337 Mon Sep 17 00:00:00 2001
From: Spencer McIntyre <zeroSteiner@gmail.com>
Date: Tue, 6 May 2025 11:23:06 -0400
Subject: [PATCH 2/2] Fix a #pack format string for Ruby 3.3

---
 spec/lib/ruby_smb/dcerpc/samr/user_properties_spec.rb | 6 +++---
 1 file changed, 3 insertions(+), 3 deletions(-)

diff --git a/spec/lib/ruby_smb/dcerpc/samr/user_properties_spec.rb b/spec/lib/ruby_smb/dcerpc/samr/user_properties_spec.rb
index ca4710999..21a96c7f0 100644
--- a/spec/lib/ruby_smb/dcerpc/samr/user_properties_spec.rb
+++ b/spec/lib/ruby_smb/dcerpc/samr/user_properties_spec.rb
@@ -1,7 +1,7 @@
 RSpec.describe RubySMB::Dcerpc::Samr::UserProperties do
   describe '#read' do
     context 'when reading a structure with no user properties' do
-      let(:binary) { [ 0, 0x63, 0, 0, 0x50, 0].pack('L<L<S<S<x96<SC') }
+      let(:binary) { [ 0, 0x63, 0, 0, 0x50, 0].pack('L<L<S<S<x96SC') }
       let(:subject) { described_class.read(binary) }
 
       it 'does not include the property_count' do
@@ -23,7 +23,7 @@
       let(:user_property1) { RubySMB::Dcerpc::Samr::UserProperty.new(property_name: 'key1', property_value: 'value1') }
       let(:user_property2) { RubySMB::Dcerpc::Samr::UserProperty.new(property_name: 'key2', property_value: 'value2') }
       let(:user_properties) { user_property1.to_binary_s + user_property2.to_binary_s }
-      let(:binary) { [ 0, 0x63 + 2 + user_properties.length, 0, 0, 0x50, 2].pack('L<L<S<S<x96<S<S') + user_properties + "\x00".b }
+      let(:binary) { [ 0, 0x63 + 2 + user_properties.length, 0, 0, 0x50, 2].pack('L<L<S<S<x96S<S') + user_properties + "\x00".b }
       let(:subject) { described_class.read(binary) }
 
       it 'includes the property_count' do
@@ -73,4 +73,4 @@
       expect(subject.user_properties).to be_empty
     end
   end
-end
\ No newline at end of file
+end