Skip to content

Fix issue #112: Prevent download window from opening on incorrect input format #114

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
Apo-orva17 wants to merge 1 commit into
base: main
Choose a base branch
from
Open

Fix issue #112: Prevent download window from opening on incorrect input format #114

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
6 changes: 3 additions & 3 deletions script.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -236,7 +236,8 @@ function validateForm() {
if (isValid) return true;

// Else ask user if they want to proceed anyway
return confirm("Please correct the highlighted errors in the form before downloading your resume.");
else alert("Please correct the highlighted errors in the form before downloading your resume.");
return false;
}


Expand All @@ -245,8 +246,7 @@ document.getElementById("downloadBtn").addEventListener("click", () => {
if (!validateForm()) return;

// --- PDF Download Button ---

const content = document.querySelector('#resume-sections');
const content = document.querySelector('#resume-sections');
const options = {
margin: 0.5,
filename: 'resume.pdf',
Expand Down