-
Notifications
You must be signed in to change notification settings - Fork 11
Open
Description
Due to some Hash160 so-called collisions we cant use checkValueSent function.
For example, we can have two BTC addresses that both have the same Hash 160, for instance:
https://blockchain.info/ru/address/17AXqoGmJ71Noc2hZvDnP1wGPZTVykXsPd
https://blockchain.info/ru/address/37rYmLmCr1Kktmj8h1tNoeJCY5kDaGHpjp
My proposition is that we need to add another argument to specify the type of BTC address (p2p, p2sh or both).
Here we need to check specifically for our type of an address.
https://github.com/rainbreak/solidity-btc-parser/blob/master/src/btc_tx.sol#L286
Metadata
Metadata
Assignees
Labels
No labels