Fix dialyze target in plugins when asdf is used
#15080
Open
+36
−3
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
[This](ninenines/erlang.mk@e13b4c7) `erlang.mk` commit fixed the detection of Elixir libraries for `asdf` users, but the "old way" remained in `rabbitmq-early-plugin.mk`. Removing the `dialyze` target env definitions fixes this issue, and, the value of `ERL_LIBS` that is set is the same. Win-win.
lukebakken
force-pushed
the
lukebakken/fix-elixir-dialyze
branch
from
6eb04f1 to
37bf911
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This
erlang.mkcommit fixed the detection of Elixir libraries forasdfusers, but the "old way" remained inrabbitmq-early-plugin.mk. Removing thedialyzetarget env definitions fixes this issue (settingELIXIR = systemis required), and, the value ofERL_LIBSthat is set is the same. Win-win.