Fix checksum validate on parse #740
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
vyourtchenko-connamara
force-pushed
the
fix-checksum-validate-on-parse
branch
from
aa70104 to
a693b59
Compare
michaelwilner
requested changes
Dec 6, 2025
| mp.msg.Header.rwLock.Unlock() | ||
| mp.msg.Body.rwLock.Unlock() | ||
| mp.msg.Trailer.rwLock.Unlock() | ||
| locked = false |
Contributor
There was a problem hiding this comment.
This is an antipattern, if you need to reduce the locked surface use a dedicated function with a defer at the top as this function previously had
Contributor
There was a problem hiding this comment.
Why did this change? I’m not sure why you need to unlock
| var expectedCheckSumStr string | ||
| expectedCheckSumStr, err = mp.msg.Trailer.GetString(tagCheckSum) | ||
| if err != nil { | ||
| return parseError{OrigError: "CheckSum tag missing"} |
Contributor
There was a problem hiding this comment.
Will this result in the message being ignored per standard FIX?
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.