Added validation test expecting a parse error

Author: vyourtchenko-connamara

validation_test.go

@@ -20,8 +20,6 @@ import (
 	"testing"
 	"time"
 
-	"github.com/stretchr/testify/assert"
-
 	"github.com/quickfixgo/quickfix/datadictionary"
 )
 
@@ -87,42 +85,60 @@ func TestValidate(t *testing.T) {
 		tcCheckUserDefinedFieldsDisabled(),
 		tcCheckUserDefinedFieldsDisabledFixT(),
 		tcMultipleRepeatingGroupFields(),
+		tcCheckSumValidation(),
 	}
 
 	msg := NewMessage()
 	for _, test := range tests {
-		assert.Nil(t, ParseMessage(msg, bytes.NewBuffer(test.MessageBytes)))
-		reject := test.Validator.Validate(msg)
+		t.Run(test.TestName, func(t *testing.T) {
+			// Check for Parse Error explicitly
+			err := ParseMessage(msg, bytes.NewBuffer(test.MessageBytes))
+
+			// --- NEW LOGIC START ---
+			if test.ExpectParseError {
+				if err == nil {
+					t.Errorf("%v: Expected ParseMessage to fail, but it succeeded", test.TestName)
+				}
+				return
+			}
+			// --- NEW LOGIC END ---
 
-		switch {
-		case reject == nil && test.DoNotExpectReject:
-			continue
+			if err != nil {
+				t.Fatalf("ParseMessage failed: %v", err)
+			}
+			//assert.Nil(t, ParseMessage(msg, bytes.NewBuffer(test.MessageBytes)))
+			reject := test.Validator.Validate(msg)
 
-		case reject != nil && test.DoNotExpectReject:
-			t.Errorf("%v: Unexpected reject: %v", test.TestName, reject)
-			continue
+			switch {
+			case reject == nil && test.DoNotExpectReject:
+				return
 
-		case reject == nil:
-			t.Errorf("%v: Expected reject", test.TestName)
-			continue
-		}
+			case reject != nil && test.DoNotExpectReject:
+				t.Errorf("%v: Unexpected reject: %v", test.TestName, reject)
+				return
 
-		if reject.RejectReason() != test.ExpectedRejectReason {
-			t.Errorf("%v: Expected reason %v got %v", test.TestName, test.ExpectedRejectReason, reject.RejectReason())
-		}
+			case reject == nil:
+				t.Errorf("%v: Expected reject", test.TestName)
+				return
+			}
 
-		switch {
-		case reject.RefTagID() == nil && test.ExpectedRefTagID == nil:
-		// OK, expected and actual ref tag not set.
-		case reject.RefTagID() != nil && test.ExpectedRefTagID == nil:
-			t.Errorf("%v: Unexpected RefTag '%v'", test.TestName, *reject.RefTagID())
-		case reject.RefTagID() == nil && test.ExpectedRefTagID != nil:
-			t.Errorf("%v: Expected RefTag '%v'", test.TestName, *test.ExpectedRefTagID)
-		case *reject.RefTagID() == *test.ExpectedRefTagID:
-			// OK, tags equal.
-		default:
-			t.Errorf("%v: Expected RefTag '%v' got '%v'", test.TestName, *test.ExpectedRefTagID, *reject.RefTagID())
-		}
+			if reject.RejectReason() != test.ExpectedRejectReason {
+				t.Errorf("%v: Expected reason %v got %v", test.TestName, test.ExpectedRejectReason, reject.RejectReason())
+			}
+
+			switch {
+			case reject.RefTagID() == nil && test.ExpectedRefTagID == nil:
+			// OK, expected and actual ref tag not set.
+			case reject.RefTagID() != nil && test.ExpectedRefTagID == nil:
+				t.Errorf("%v: Unexpected RefTag '%v'", test.TestName, *reject.RefTagID())
+			case reject.RefTagID() == nil && test.ExpectedRefTagID != nil:
+				t.Errorf("%v: Expected RefTag '%v'", test.TestName, *test.ExpectedRefTagID)
+			case *reject.RefTagID() == *test.ExpectedRefTagID:
+				// OK, tags equal.
+			default:
+				t.Errorf("%v: Expected RefTag '%v' got '%v'", test.TestName, *test.ExpectedRefTagID, *reject.RefTagID())
+			}
+		})
 	}
 }
 
@@ -1170,6 +1186,17 @@ func tcMultipleRepeatingGroupFields() validateTest {
 	}
 }
 
+func tcCheckSumValidation() validateTest {
+	dict, _ := datadictionary.Parse("spec/FIX43.xml")
+	validator := NewValidator(defaultValidatorSettings, dict, nil)
+	return validateTest{
+		TestName:         "Checksum is incorrect",
+		Validator:        validator,
+		MessageBytes:     []byte("8=FIX.4.3
9=176
35=D
34=2
49=TW
52=20140329-22:38:45
56=ISLD
11=ID
453=2
448=PARTYID
452=3
523=SUBID
448=PARTYID2
452=3
78=1
79=ACCOUNT
80=1
21=1
40=1
54=1
38=200
55=INTC
60=20140329-22:38:45
10=006
"),
+		ExpectParseError: true,
+	}
+}
+
 func TestValidateVisitField(t *testing.T) {
 	fieldType0 := datadictionary.NewFieldType("myfield", 11, "STRING")
 	fieldDef0 := &datadictionary.FieldDef{FieldType: fieldType0}