Skip to content

Conversation

@jgibson2
Copy link
Contributor

@jgibson2 jgibson2 commented Dec 6, 2025

Summary

Adds the ability to specify a set of CoreML passes as a CompileSpec, allowing additional customization of the model compilation.

Test plan

Converted a model and made sure it worked with a custom pipeline. Also ensured via print statements that the passes were translated correctly.

@jgibson2 jgibson2 requested a review from shoumikhin as a code owner December 6, 2025 04:10
Copilot AI review requested due to automatic review settings December 6, 2025 04:10
@jgibson2 jgibson2 requested a review from cccclai as a code owner December 6, 2025 04:10
@pytorch-bot
Copy link

pytorch-bot bot commented Dec 6, 2025

🔗 Helpful Links

🧪 See artifacts and rendered test results at hud.pytorch.org/pr/pytorch/executorch/16118

Note: Links to docs will display an error until the docs builds have been completed.

✅ No Failures

As of commit d9174e4 with merge base 9193566 (image):
💚 Looks good so far! There are no failures yet. 💚

This comment was automatically generated by Dr. CI and updates every 15 minutes.

@meta-cla meta-cla bot added the CLA Signed This label is managed by the Facebook bot. Authors need to sign the CLA before a PR can be reviewed. label Dec 6, 2025
Copy link
Contributor

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

This PR adds the ability to specify a custom CoreML pass pipeline through the CompileSpec system, enabling users to customize the model compilation process beyond the default pipeline.

Key Changes:

  • Added PASS_PIPELINE key to the compile spec enumeration
  • Implemented methods to serialize/deserialize pass pipeline configurations
  • Integrated custom pass pipeline into the CoreML conversion process

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

@jgibson2
Copy link
Contributor Author

jgibson2 commented Dec 6, 2025

@pytorchbot label "release notes: none"

@pytorch-bot pytorch-bot bot added the release notes: none Do not include this in the release notes label Dec 6, 2025
@jgibson2 jgibson2 changed the title Add ability to specify CoreML pipeline passses Add ability to specify CoreML pipeline passes Dec 6, 2025
Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com>
Copilot AI review requested due to automatic review settings December 6, 2025 04:12
Copy link
Contributor

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

Copilot reviewed 1 out of 1 changed files in this pull request and generated 3 comments.


💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

CLA Signed This label is managed by the Facebook bot. Authors need to sign the CLA before a PR can be reviewed. release notes: none Do not include this in the release notes

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant