Using push constants for add mm native op. #16115
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Summary: The softmax operation has been updated to utilize push constants for efficient data transfer. Differential Revision: D88097603
Summary: This diff modifies the clone operation in the Executorch Vulkan backend to use push constants instead of a uniform buffer for storing the output limits. Differential Revision: D88097604
Summary: The diff modifies the `BinaryScalarOp` implementation to utilize push constants for the scalar value parameter. Differential Revision: D88097606
Summary: The change replaces the shader params buffer with push constants in the add mm native op. This simplifies the shader and reduces the number of buffers used. Differential Revision: D88097601
🔗 Helpful Links🧪 See artifacts and rendered test results at hud.pytorch.org/pr/pytorch/executorch/16115
Note: Links to docs will display an error until the docs builds have been completed. ❌ 2 New Failures, 1 Unrelated FailureAs of commit 151b8cf with merge base 4014597 ( NEW FAILURES - The following jobs have failed:
BROKEN TRUNK - The following job failed but were present on the merge base:👉 Rebase onto the `viable/strict` branch to avoid these failures
This comment was automatically generated by Dr. CI and updates every 15 minutes. |
meta-cla
bot
added
the
CLA Signed
|
@trivedivivek has exported this pull request. If you are a Meta employee, you can view the originating Diff in D88097601. |
trivedivivek
added
the
release notes: vulkan
yipjustin
approved these changes
Dec 5, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary: The change replaces the shader params buffer with push constants in the add mm native op. This simplifies the shader and reduces the number of buffers used.
Differential Revision: D88097601