-
Notifications
You must be signed in to change notification settings - Fork 749
Adding Test for CadenceWith16BitMatmulActivationsQuantizer #16089
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: main
Are you sure you want to change the base?
Conversation
Summary: We test the quantizer we added in D87996796 correctly annotates the graph. We use the graph builder to build the graph with metadata(that's needed for quantizer.annotate to recognize the nodes), and we ensure that the quantization params are as expected. Reviewed By: hsharma35 Differential Revision: D88053808
🔗 Helpful Links🧪 See artifacts and rendered test results at hud.pytorch.org/pr/pytorch/executorch/16089
Note: Links to docs will display an error until the docs builds have been completed. ❌ 1 New Failure, 1 Unrelated FailureAs of commit 9c942f2 with merge base a09a4b7 ( NEW FAILURE - The following job has failed:
BROKEN TRUNK - The following job failed but were present on the merge base:👉 Rebase onto the `viable/strict` branch to avoid these failures
This comment was automatically generated by Dr. CI and updates every 15 minutes. |
This PR needs a
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Pull request overview
This PR adds a unit test for the CadenceWith16BitMatmulActivationsQuantizer class that was introduced in D87996796. The test verifies that the quantizer correctly annotates matmul operations with 16-bit activation quantization specifications.
- Adds a new test class
QuantizerAnnotationTestwith a helper method to build matmul graphs usingGraphBuilder - Tests that the quantizer correctly annotates matmul nodes with A16 (16-bit activation) quantization specs
- Updates TARGETS file to include necessary dependencies for graph building and quantization annotation testing
Reviewed changes
Copilot reviewed 2 out of 2 changed files in this pull request and generated no comments.
| File | Description |
|---|---|
| backends/cadence/aot/tests/test_quantizer_ops.py | Adds QuantizerAnnotationTest class with test for 16-bit matmul quantizer annotation verification |
| backends/cadence/aot/TARGETS | Adds dependencies for graph_builder, pass_base, and torchao required by the new test |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
…6089) Summary: We test the quantizer we added in D87996796 correctly annotates the graph. We use the graph builder to build the graph with metadata(that's needed for quantizer.annotate to recognize the nodes), and we ensure that the quantization params are as expected. Reviewed By: hsharma35 Differential Revision: D88053808
…6089) Summary: We test the quantizer we added in D87996796 correctly annotates the graph. We use the graph builder to build the graph with metadata(that's needed for quantizer.annotate to recognize the nodes), and we ensure that the quantization params are as expected. Reviewed By: hsharma35 Differential Revision: D88053808
…6089) Summary: We test the quantizer we added in D87996796 correctly annotates the graph. We use the graph builder to build the graph with metadata(that's needed for quantizer.annotate to recognize the nodes), and we ensure that the quantization params are as expected. Reviewed By: hsharma35 Differential Revision: D88053808
Summary:
We test the quantizer we added in D87996796 correctly annotates the graph.
We use the graph builder to build the graph with metadata(that's needed for quantizer.annotate to recognize the nodes), and we ensure that the quantization params are as expected.
Reviewed By: hsharma35
Differential Revision: D88053808