Skip to content

Conversation

@RahulC7
Copy link
Contributor

@RahulC7 RahulC7 commented Dec 4, 2025

Summary:
We test the quantizer we added in D87996796 correctly annotates the graph.

We use the graph builder to build the graph with metadata(that's needed for quantizer.annotate to recognize the nodes), and we ensure that the quantization params are as expected.

Reviewed By: hsharma35

Differential Revision: D88053808

Summary:
We test the quantizer we added in D87996796 correctly annotates the graph. 

We use the graph builder to build the graph with metadata(that's needed for quantizer.annotate to recognize the nodes), and we ensure that the quantization params are as expected.

Reviewed By: hsharma35

Differential Revision: D88053808
Copilot AI review requested due to automatic review settings December 4, 2025 23:13
@pytorch-bot
Copy link

pytorch-bot bot commented Dec 4, 2025

🔗 Helpful Links

🧪 See artifacts and rendered test results at hud.pytorch.org/pr/pytorch/executorch/16089

Note: Links to docs will display an error until the docs builds have been completed.

❌ 1 New Failure, 1 Unrelated Failure

As of commit 9c942f2 with merge base a09a4b7 (image):

NEW FAILURE - The following job has failed:

BROKEN TRUNK - The following job failed but were present on the merge base:

👉 Rebase onto the `viable/strict` branch to avoid these failures

This comment was automatically generated by Dr. CI and updates every 15 minutes.

@meta-cla meta-cla bot added the CLA Signed This label is managed by the Facebook bot. Authors need to sign the CLA before a PR can be reviewed. label Dec 4, 2025
@meta-codesync
Copy link

meta-codesync bot commented Dec 4, 2025

@RahulC7 has exported this pull request. If you are a Meta employee, you can view the originating Diff in D88053808.

@github-actions
Copy link

github-actions bot commented Dec 4, 2025

This PR needs a release notes: label

If your change should be included in the release notes (i.e. would users of this library care about this change?), please use a label starting with release notes:. This helps us keep track and include your important work in the next release notes.

To add a label, you can comment to pytorchbot, for example
@pytorchbot label "release notes: none"

For more information, see
https://github.com/pytorch/pytorch/wiki/PyTorch-AutoLabel-Bot#why-categorize-for-release-notes-and-how-does-it-work.

Copilot finished reviewing on behalf of RahulC7 December 4, 2025 23:16
Copy link
Contributor

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

This PR adds a unit test for the CadenceWith16BitMatmulActivationsQuantizer class that was introduced in D87996796. The test verifies that the quantizer correctly annotates matmul operations with 16-bit activation quantization specifications.

  • Adds a new test class QuantizerAnnotationTest with a helper method to build matmul graphs using GraphBuilder
  • Tests that the quantizer correctly annotates matmul nodes with A16 (16-bit activation) quantization specs
  • Updates TARGETS file to include necessary dependencies for graph building and quantization annotation testing

Reviewed changes

Copilot reviewed 2 out of 2 changed files in this pull request and generated no comments.

File Description
backends/cadence/aot/tests/test_quantizer_ops.py Adds QuantizerAnnotationTest class with test for 16-bit matmul quantizer annotation verification
backends/cadence/aot/TARGETS Adds dependencies for graph_builder, pass_base, and torchao required by the new test

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

RahulC7 added a commit to RahulC7/executorch that referenced this pull request Dec 5, 2025
…6089)

Summary:

We test the quantizer we added in D87996796 correctly annotates the graph. 

We use the graph builder to build the graph with metadata(that's needed for quantizer.annotate to recognize the nodes), and we ensure that the quantization params are as expected.

Reviewed By: hsharma35

Differential Revision: D88053808
RahulC7 added a commit to RahulC7/executorch that referenced this pull request Dec 5, 2025
…6089)

Summary:

We test the quantizer we added in D87996796 correctly annotates the graph. 

We use the graph builder to build the graph with metadata(that's needed for quantizer.annotate to recognize the nodes), and we ensure that the quantization params are as expected.

Reviewed By: hsharma35

Differential Revision: D88053808
RahulC7 added a commit to RahulC7/executorch that referenced this pull request Dec 5, 2025
…6089)

Summary:

We test the quantizer we added in D87996796 correctly annotates the graph. 

We use the graph builder to build the graph with metadata(that's needed for quantizer.annotate to recognize the nodes), and we ensure that the quantization params are as expected.

Reviewed By: hsharma35

Differential Revision: D88053808
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

CLA Signed This label is managed by the Facebook bot. Authors need to sign the CLA before a PR can be reviewed. fb-exported meta-exported

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants