Skip to content

Commit 7a29e98

Browse files
authored
fix: remove warning about earlystop and save best model (#73)
1 parent a96cd7f commit 7a29e98

File tree

3 files changed

+4
-19
lines changed

3 files changed

+4
-19
lines changed

templates/_base/_sidebar.py

Lines changed: 0 additions & 9 deletions
Original file line numberDiff line numberDiff line change
@@ -152,11 +152,6 @@ def _save_best_model_by_val_score_options(config):
152152
"Save the best model by evaluation score",
153153
value=False,
154154
)
155-
if config["save_best_model_by_val_score"]:
156-
st.warning(
157-
"Please make sure to pass argument to `metric_name` parameter of `get_handlers` in `main.py`."
158-
" Otherwise it can result KeyError.",
159-
)
160155
st.markdown("---")
161156

162157

@@ -171,8 +166,4 @@ def _add_early_stopping_by_val_score_options(config):
171166
min_value=1,
172167
value=3,
173168
)
174-
st.warning(
175-
"Please make sure to pass argument to `es_metric_name` parameter of `get_handlers` in `main.py`."
176-
" Otherwise it can result KeyError.",
177-
)
178169
st.markdown("---")

templates/gan/main.py

Lines changed: 3 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -109,9 +109,9 @@ def run(local_rank: int, config: Any, *args: Any, **kwargs: Any):
109109
config=config,
110110
model={'netD', netD, 'netG', netG},
111111
train_engine=train_engine,
112-
eval_engine=None,
113-
metric_name=None,
114-
es_metric_name=None,
112+
eval_engine=train_engine,
113+
metric_name='errD',
114+
es_metric_name='errD',
115115
to_save=to_save,
116116
lr_scheduler=lr_scheduler,
117117
output_names=["errD", "errG", "D_x", "D_G_z1", "D_G_z2"],

templates/image_classification/main.py

Lines changed: 1 addition & 7 deletions
Original file line numberDiff line numberDiff line change
@@ -122,13 +122,7 @@ def run(local_rank: int, config: Any, *args: Any, **kwargs: Any):
122122
train_engine=train_engine,
123123
eval_engine=eval_engine,
124124
metric_name="eval_accuracy",
125-
# TODO : replace with the metric name to save the best model
126-
# if you check `Save the best model by evaluation score` otherwise leave it None
127-
# metric must be in eval_engine.state.metrics.
128-
es_metric_name=None,
129-
# TODO : replace with the metric name to early stop
130-
# if you check `Early stop the training by evaluation score` otherwise leave it None
131-
# metric must be in eval_engine.state.metrics.
125+
es_metric_name="eval_accuracy",
132126
to_save=to_save,
133127
lr_scheduler=lr_scheduler,
134128
output_names=None,

0 commit comments

Comments
 (0)