Skip to content

Commit 5e749d3

Browse files
authored
Fix multiprocessing queue test_get() (GH-142024)
* Replace sleep() with support.sleeping_retry(). * Test get_nowait() first. * Restore previously disabled test. Fix the failure: FAIL: test_get (test.test_multiprocessing_spawn.test_processes.WithProcessesTestQueue.test_get) ---------------------------------------------------------------------- Traceback (most recent call last): File "Lib/test/_test_multiprocessing.py", line 1208, in test_get self.assertEqual(queue_empty(queue), False) ~~~~~~~~~~~~~~~~^^^^^^^^^^^^^^^^^^^^^^^^^^^ AssertionError: True != False
1 parent 5b1862b commit 5e749d3

File tree

1 file changed

+6
-5
lines changed

1 file changed

+6
-5
lines changed

Lib/test/_test_multiprocessing.py

Lines changed: 6 additions & 5 deletions
Original file line numberDiff line numberDiff line change
@@ -1204,7 +1204,7 @@ def test_put(self):
12041204
@classmethod
12051205
def _test_get(cls, queue, child_can_start, parent_can_continue):
12061206
child_can_start.wait()
1207-
#queue.put(1)
1207+
queue.put(1)
12081208
queue.put(2)
12091209
queue.put(3)
12101210
queue.put(4)
@@ -1229,15 +1229,16 @@ def test_get(self):
12291229
child_can_start.set()
12301230
parent_can_continue.wait()
12311231

1232-
time.sleep(DELTA)
1232+
for _ in support.sleeping_retry(support.SHORT_TIMEOUT):
1233+
if not queue_empty(queue):
1234+
break
12331235
self.assertEqual(queue_empty(queue), False)
12341236

1235-
# Hangs unexpectedly, remove for now
1236-
#self.assertEqual(queue.get(), 1)
1237+
self.assertEqual(queue.get_nowait(), 1)
12371238
self.assertEqual(queue.get(True, None), 2)
12381239
self.assertEqual(queue.get(True), 3)
12391240
self.assertEqual(queue.get(timeout=1), 4)
1240-
self.assertEqual(queue.get_nowait(), 5)
1241+
self.assertEqual(queue.get(), 5)
12411242

12421243
self.assertEqual(queue_empty(queue), True)
12431244

0 commit comments

Comments
 (0)