Validate and reset altered metatized objects

Author: brandonwillard

symbolic_pymc/tensorflow/meta.py

@@ -189,6 +189,23 @@ def _metatize_tf_eager(obj):
 class TFlowMetaSymbol(MetaSymbol):
     __slots__ = ()
 
+    @classmethod
+    def _metatize(cls, obj):
+
+        res = super()._metatize(obj)
+        res.validate_objs()
+
+        return res
+
+    def validate_objs(self):
+        # If there is no base object associated with the inputs, then we can't
+        # trust a base object associated with this object (e.g. for the case in
+        # which metatize altered a property in an input).
+        for prop in self.rands():
+            if isinstance(prop, MetaSymbol) and prop.obj is None:
+                self.reset()
+                break
+
 
 class OpDefFactoryType(MetaSymbolType):
     __opdefs__ = {}
@@ -501,8 +518,7 @@ def _metatize(cls, obj):
         ]
         res = cls(*new_args, obj=obj)
 
-        if meta._lvar_defaults_enabled.issuperset(["node_attrs", "names"]):
-            res.reset()
+        res.validate_objs()
 
         return res
 
@@ -688,13 +704,8 @@ class TFlowMetaTensor(TFlowMetaSymbol, MetaVariable):
     @classmethod
     @cachedmethod(lambda cls: tf_metatize_cache)
     def _metatize(cls, obj):
-
-        res = super()._metatize(obj)
-
-        if meta._lvar_defaults_enabled.issuperset(["node_attrs", "names"]):
-            res.reset()
-
-        return res
+        """Cache Tensors specifically."""
+        return super()._metatize(obj)
 
     def __init__(self, op, value_index, dtype, obj=None):
         self.op = metatize(op)

tests/tensorflow/test_meta.py

@@ -593,3 +593,8 @@ def test_global_options():
         assert isvar(b_mt.name)
         assert isvar(b_mt.op.node_def.attr)
         assert b_mt.op.inputs[1] is a_mt
+
+    # Make sure we clear out the `.obj` so that the names won't mismatch
+    with tf.Graph().as_default(), enable_lvar_defaults('names'):
+        a_mt = mt(1.0)
+        assert isvar(a_mt.name)