Don't send notification email during import export process (#233)

- Skip Sending notification during import export process.

Author: Mariatta

sponsorship/admin.py

@@ -13,6 +13,10 @@ class SponsorshipTierAdmin(admin.ModelAdmin):
 
 
 class SponsorshipProfileResource(resources.ModelResource):
+    def before_save_instance(self, instance, row, **kwargs):
+        # during 'confirm' step, dry_run is True
+        instance.from_import_export = True
+
     class Meta:
         model = SponsorshipProfile
         fields = (

sponsorship/signals.py

@@ -84,8 +84,13 @@ def send_internal_sponsor_progress_update_email(instance):
 
 @receiver(post_save, sender=SponsorshipProfile)
 def sponsorship_profile_signal(sender, instance, created, **kwargs):
-    """Send emails when sponsorship profile is created or updated."""
-    if created:
-        send_internal_sponsor_onboarding_email(instance)
+    """Send emails when sponsorship profile is created or updated.
+    Do not send emails if the instance was created via import/export. (too noisy).
+    """
+    if hasattr(instance, "from_import_export"):
+        return
     else:
-        send_internal_sponsor_progress_update_email(instance)
+        if created:
+            send_internal_sponsor_onboarding_email(instance)
+        else:
+            send_internal_sponsor_progress_update_email(instance)

tests/sponsorship/test_admin.py

@@ -0,0 +1,54 @@
+from django.core import mail
+from tablib import Dataset
+
+from sponsorship.admin import SponsorshipProfileResource
+from sponsorship.models import (
+    SponsorshipProgressStatus,
+)
+
+
+class TestSponsorshipImportExport:
+    def test_import_sponsorship_does_not_trigger_email(self, admin_user):
+        dataset = Dataset()
+        dataset.headers = [
+            "id",
+            "organization_name",
+            "sponsor_contact_name",
+            "sponsors_contact_email",
+            "sponsorship_tier",
+            "progress_status",
+            "sponsorship_override_amount",
+            "main_contact_user",
+        ]
+        dataset.append(
+            [
+                "",
+                "Test 1",
+                "",
+                "",
+                "",
+                SponsorshipProgressStatus.AWAITING_RESPONSE.value,
+                "",
+                str(admin_user.id),
+            ]
+        )
+
+        dataset.append(
+            [
+                "",
+                "Test 2",
+                "",
+                "",
+                "",
+                SponsorshipProgressStatus.PAID.value,
+                "",
+                str(admin_user.id),
+            ]
+        )
+
+        resource = SponsorshipProfileResource()
+        mail.outbox.clear()
+        resource.import_data(dataset, dry_run=False)
+        assert len(mail.outbox) == 0  # no email
+        resource.import_data(dataset, dry_run=True)
+        assert len(mail.outbox) == 0  # no email