operations/files.copy: noop if file already exists

Author: EricDriussi

src/pyinfra/operations/files.py

@@ -1331,7 +1331,11 @@ def copy(src: str, dest: str, overwrite=False):
     dest_file_path = os.path.join(dest, os.path.basename(src))
     dest_file_exists = host.get_fact(File, dest_file_path)
     if dest_file_exists and not overwrite:
-        raise OperationError(f"dest {dest_file_path} already exists and `overwrite` is unset")
+        if _file_equal(src, dest_file_path):
+            host.noop(f"{dest_file_path} already exists")
+            return
+        else:
+            raise OperationError(f"{dest_file_path} already exists and is different than src")
 
     cp_cmd = ["cp -r"]
 

tests/operations/files.copy/invalid_overwrite.json

@@ -4,6 +4,11 @@
         "dest": "/tmp/dest_dir",
         "overwrite": false
     },
+    "local_files": {
+        "files": {
+            "/tmp/src_dir/file": "some content"
+        }
+    },
     "facts": {
         "files.File": {
             "path=/tmp/src_dir/file": true,
@@ -12,10 +17,14 @@
         "files.Directory": {
             "path=/tmp/dest_dir": true,
             "path=/tmp/src_dir/file": null
+        },
+        "files.Sha1File": {
+            "path=/tmp/src_dir/file": "abc",
+            "path=/tmp/dest_dir/file": "xyz"
         }
     },
     "exception": {
         "name": "OperationError",
-        "message": "dest /tmp/dest_dir/file already exists and `overwrite` is unset"
+        "message": "/tmp/dest_dir/file already exists and is different than src"
     }
 }

tests/operations/files.copy/noop_dest_file_exists.json

@@ -0,0 +1,23 @@
+{
+    "kwargs": {
+        "src": "/tmp/src_dir/file",
+        "dest": "/tmp/dest_dir",
+        "overwrite": false
+    },
+    "facts": {
+        "files.File": {
+            "path=/tmp/src_dir/file": true,
+            "path=/tmp/dest_dir/file": true
+        },
+        "files.Directory": {
+            "path=/tmp/dest_dir": true,
+            "path=/tmp/src_dir/file": null
+        },
+        "files.Sha1File": {
+            "path=/tmp/src_dir/file": "94e66df8cd09d410c62d9e0dc59d3a884e458e05",
+            "path=/tmp/dest_dir/file": "94e66df8cd09d410c62d9e0dc59d3a884e458e05"
+        }
+    },
+    "commands": [],
+    "noop_description": "/tmp/dest_dir/file already exists"
+}