Replace PyModule_AddObjectRef with PyModule_Add for surface capi

oddbookworm · oddbookworm · commit a0688ebe0e04 · 2025-05-24T13:43:32.000-05:00
diff --git a/src_c/surface.c b/src_c/surface.c
@@ -4623,8 +4623,7 @@ exec_surface(PyObject *module)
     c_api[2] = pgSurface_Blit;
     c_api[3] = pgSurface_SetSurface;
     apiobj = encapsulate_api(c_api, "surface");
-    if (PyModule_AddObjectRef(module, PYGAMEAPI_LOCAL_ENTRY, apiobj)) {
-        Py_XDECREF(apiobj);
+    if (PyModule_Add(module, PYGAMEAPI_LOCAL_ENTRY, apiobj) < 0) {
         return -1;
     }
 

Original file line number	Diff line number	Diff line change
`@@ -4623,8 +4623,7 @@ exec_surface(PyObject *module)`
`4623`	`4623`	`c_api[2] = pgSurface_Blit;`
`4624`	`4624`	`c_api[3] = pgSurface_SetSurface;`
`4625`	`4625`	`apiobj = encapsulate_api(c_api, "surface");`
`4626`		`- if (PyModule_AddObjectRef(module, PYGAMEAPI_LOCAL_ENTRY, apiobj)) {`
`4627`		`- Py_XDECREF(apiobj);`
	`4626`	`+ if (PyModule_Add(module, PYGAMEAPI_LOCAL_ENTRY, apiobj) < 0) {`
`4628`	`4627`	`return -1;`
`4629`	`4628`	`}`
`4630`	`4629`