From a5f28a8d85c3a881bd80abf049375271afdbfa2e Mon Sep 17 00:00:00 2001 From: arbazkhan002 Date: Mon, 8 Jan 2018 17:21:39 -0800 Subject: [PATCH] rounding-off comparison with B-spline's bounds --- patsy/splines.py | 6 ++++-- 1 file changed, 4 insertions(+), 2 deletions(-) diff --git a/patsy/splines.py b/patsy/splines.py index 2a2faa2..7010fdc 100644 --- a/patsy/splines.py +++ b/patsy/splines.py @@ -216,12 +216,14 @@ def memorize_finish(self): inner_knots = np.asarray(inner_knots) if inner_knots.ndim > 1: raise ValueError("knots must be 1 dimensional") - if np.any(inner_knots < lower_bound): + if (np.any(inner_knots < lower_bound) and not + np.isclose(np.amin(inner_knots), lower_bound)): raise ValueError("some knot values (%s) fall below lower bound " "(%r)" % (inner_knots[inner_knots < lower_bound], lower_bound)) - if np.any(inner_knots > upper_bound): + if (np.any(inner_knots > upper_bound) and not + np.isclose(np.amax(inner_knots), upper_bound)): raise ValueError("some knot values (%s) fall above upper bound " "(%r)" % (inner_knots[inner_knots > upper_bound],