CI fixes

Author: oremanj

include/pybind11/detail/common.h

@@ -214,6 +214,12 @@
 #    define PYBIND11_SIMPLE_GIL_MANAGEMENT
 #endif
 
+#if defined(_MSC_VER)
+#    define PYBIND11_COMPAT_STRDUP _strdup
+#else
+#    define PYBIND11_COMPAT_STRDUP strdup
+#endif
+
 #include <cstddef>
 #include <cstring>
 #include <exception>

include/pybind11/detail/foreign.h

@@ -405,7 +405,7 @@ PYBIND11_NOINLINE void export_type_to_foreign(type_info *ti) {
     binding->framework = foreign_internals.self.get();
     binding->pytype = ti->type;
     binding->native_type = ti->cpptype;
-    binding->source_name = strdup(clean_type_id(ti->cpptype->name()).c_str());
+    binding->source_name = PYBIND11_COMPAT_STRDUP(clean_type_id(ti->cpptype->name()).c_str());
     binding->context = ti;
 
     capsule tie_lifetimes((void *) binding, [](void *p) {

include/pybind11/detail/type_caster_base.h

@@ -1717,7 +1717,7 @@ class type_caster_base : public type_caster_generic {
         handle ret, std::shared_ptr<const void> holder, pymb_framework *framework) {
         // Make the resulting Python object keep a shared_ptr<T> alive,
         // even if there's not space for it inside the object.
-        std::unique_ptr<std::shared_ptr<const void>> sp{new auto{std::move(holder)}};
+        std::unique_ptr<std::shared_ptr<const void>> sp{new auto(std::move(holder))};
         if (-1 == framework->keep_alive(ret.ptr(), sp.get(), [](void *p) noexcept {
                 delete (std::shared_ptr<const void> *) p;
             })) {

include/pybind11/pybind11.h

@@ -161,7 +161,7 @@ inline std::string generate_function_signature(const char *type_caster_name_fiel
             if (handle th = detail::get_type_handle(*t, false, true)) {
                 signature += th.attr("__module__").cast<std::string>() + "."
                              + th.attr("__qualname__").cast<std::string>();
-            } else if (auto th = detail::global_internals_native_enum_type_map_get_item(*t)) {
+            } else if ((th = detail::global_internals_native_enum_type_map_get_item(*t))) {
                 signature += th.attr("__module__").cast<std::string>() + "."
                              + th.attr("__qualname__").cast<std::string>();
             } else if (func_rec->is_new_style_constructor && arg_index == 0) {
@@ -242,12 +242,6 @@ inline std::string generate_type_signature() {
         caster_name_field.text, &func_rec, descr_types.data(), type_index, arg_index);
 }
 
-#if defined(_MSC_VER)
-#    define PYBIND11_COMPAT_STRDUP _strdup
-#else
-#    define PYBIND11_COMPAT_STRDUP strdup
-#endif
-
 PYBIND11_NAMESPACE_END(detail)
 
 /// Wraps an arbitrary C++ function/method/lambda function/.. into a callable Python object

tests/test_buffers.cpp

@@ -227,7 +227,7 @@ TEST_SUBMODULE(buffers, m) {
                               + std::to_string(cols) + "(*" + std::to_string(col_factor)
                               + ") matrix");
         }
-
+        DiscontiguousMatrix(const DiscontiguousMatrix&) = delete;
         ~DiscontiguousMatrix() {
             print_destroyed(this,
                             std::to_string(rows() / m_row_factor) + "(*"

tests/test_class.cpp

@@ -521,6 +521,7 @@ TEST_SUBMODULE(class_, m) {
     // test_exception_rvalue_abort
     struct PyPrintDestructor {
         PyPrintDestructor() = default;
+        PyPrintDestructor(const PyPrintDestructor&) = default;
         ~PyPrintDestructor() { py::print("Print from destructor"); }
         void throw_something() { throw std::runtime_error("error"); }
     };

tests/test_class_release_gil_before_calling_cpp_dtor.cpp

@@ -22,6 +22,7 @@ struct ProbeType {
 
 public:
     explicit ProbeType(const std::string &unique_key) : unique_key{unique_key} {}
+    ProbeType(const ProbeType&) = default;
 
     ~ProbeType() {
         RegistryType &reg = PyGILState_Check_Results();

tests/test_cross_module_rtti/lib.h

@@ -12,6 +12,7 @@ __pragma(warning(disable : 4251))
     class TEST_CROSS_MODULE_RTTI_LIB_EXPORT Base : public std::enable_shared_from_this<Base> {
     public:
         Base(int a, int b);
+        Base(const Base&) = default;
         virtual ~Base() = default;
 
         virtual int get() const;

tests/test_eigen_matrix.cpp

@@ -237,6 +237,7 @@ TEST_SUBMODULE(eigen_matrix, m) {
 
     public:
         ReturnTester() { print_created(this); }
+        ReturnTester(const ReturnTester&) = default;
         ~ReturnTester() { print_destroyed(this); }
         static Eigen::MatrixXd create() { return Eigen::MatrixXd::Ones(10, 10); }
         // NOLINTNEXTLINE(readability-const-return-type)

tests/test_numpy_array.cpp

@@ -282,6 +282,7 @@ TEST_SUBMODULE(numpy_array, sm) {
     struct ArrayClass {
         int data[2] = {1, 2};
         ArrayClass() { py::print("ArrayClass()"); }
+        ArrayClass(const ArrayClass&) = default;
         ~ArrayClass() { py::print("~ArrayClass()"); }
     };
     py::class_<ArrayClass>(sm, "ArrayClass")