Math migration (#18)

* Add constants that currently live in purescript-math

* Add core math functions that currently live in purescript-math. Also export constants

* Remove dependency on purescript-math

* Update CHANGELOG

* Update documentation in README.md and a little in Number.purs

* Add tests for math functions

* Fix warning and remove extraneous comment in test/Main.purs

* Fix comment to remainder

Co-authored-by: Harry Garrood <harry@garrood.me>

* Fix comment to sqrt1_2

Co-authored-by: Harry Garrood <harry@garrood.me>

* Rework tests in terms of eqAbsolute

* Move examples from README.md to Data.Number

* Update trig examples to use pi

* Convert trunc from Purescript to Javascript with polyfill, similar to sign

* Update exp and log docs

Co-authored-by: Harry Garrood <harry@garrood.me>
Co-authored-by: Jordan Martinez <jordanalex.martinez@protonmail.com>

Author: 3 people

CHANGELOG.md

@@ -7,10 +7,22 @@ Notable changes to this project are documented in this file. The format is based
 Breaking changes:
 
 New features:
+- Ported various functions & constants from `purescript-math` (#18 by @JamieBallingall)
+
+  Specifically...
+  - `abs`, `sign`
+  - `max`, `min` (which work differently than `Number`'s `Ord` instance)
+  - `ceil`, `floor`, `trunc`, `remainder`/`%`, `round`
+  - `log`
+  - `exp`, `pow`, `sqrt`
+  - `acos`, `asin`, `atan`, `atan2`, `cos`, `sin`, `tan`
+  - Numeric constants: `e`, `ln2`, `ln10`, `log10e`, `log2e`, `pi`, `sqrt1_2`,
+  `sqrt2`, and `tau`
 
 Bugfixes:
 
 Other improvements:
+- Removed dependency on `purescript-math`
 
 ## [v8.0.0](https://github.com/purescript/purescript-numbers/releases/tag/v7.0.0) - 2021-02-26
 

README.md

@@ -12,52 +12,23 @@ Utility functions for working with PureScripts builtin `Number` type.
 spago install numbers
 ```
 
-## Examples
-
-Parsing:
-
-```purs
-> fromString "12.34"
-(Just 12.34)
-
-> fromString "1e-3"
-(Just 0.001)
-```
-
-Formatting (`Data.Number.Format`):
-
-```purs
-> let x = 1234.56789
-
-> toStringWith (precision 6) x
-"1234.57"
-
-> toStringWith (fixed 3) x
-"1234.568"
-
-> toStringWith (exponential 2) x
-"1.23e+3"
-```
-
-Approximate comparisons (`Data.Number.Approximate`):
-
-```purs
-> 0.1 + 0.2 == 0.3
-false
-
-> 0.1 + 0.2 ≅ 0.3
-true
-```
-
-_NaN_ and _infinity_:
-
-```purs
-> isNaN (Math.asin 2.0)
-true
-
-> isFinite (1.0 / 0.0)
-false
-```
+## Scope
+
+* Parsing with `fromString`
+* Formating with `toStringWith`, see `Data.Number.Format`
+* Approximate comparisions with `≅`, see `Data.Number.Approximate`
+* Not-a-number and infinite value detection with `isNaN` and `isFinite`
+* Remainder with `%`
+* Trignometric functions with `sin`, `cos`, `tan`, `asin`, `acos`, `atan`, and
+  `atan2`
+* Natural logarithm and exponents with `log` and `exp`
+* Powers with `sqrt` and `pow`
+* Rounding with `ceil`, `floor`, `round`, and `trunc`
+* Numeric minimum and maximum with `min` and `max`, which behave differently to
+  the versions in `Data.Ord` on values of `NaN`
+* Sign and absolute value functions `sign` and `abs`
+* Numeric constants `e`, `ln 2`, `ln10`, `log10e`, `log2e`, `pi`, `sqrt1_2`,
+  `sqrt2`, and `tau`
 
 ## Documentation
 

bower.json

@@ -17,7 +17,6 @@
   ],
   "dependencies": {
     "purescript-functions": "master",
-    "purescript-math": "master",
     "purescript-maybe": "master"
   },
   "devDependencies": {

src/Data/Number.js

@@ -14,3 +14,67 @@ export function fromStringImpl(str, isFinite, just, nothing) {
     return nothing;
   }
 }
+
+export const abs = Math.abs;
+
+export const acos = Math.acos;
+
+export const asin = Math.asin;
+
+export const atan = Math.atan;
+
+export const atan2 = function (y) {
+  return function (x) {
+    return Math.atan2(y, x);
+  };
+};
+
+export const ceil = Math.ceil;
+
+export const cos = Math.cos;
+
+export const exp = Math.exp;
+
+export const floor = Math.floor;
+
+export const log = Math.log;
+
+export const max = function (n1) {
+  return function (n2) {
+    return Math.max(n1, n2);
+  };
+};
+
+export const min = function (n1) {
+  return function (n2) {
+    return Math.min(n1, n2);
+  };
+};
+
+export const pow = function (n) {
+  return function (p) {
+    return Math.pow(n, p);
+  };
+};
+
+export const remainder = function (n) {
+  return function (m) {
+    return n % m;
+  };
+};
+
+export const round = Math.round;
+
+export const sign = Math.sign ? Math.sign : function(x) {
+  return x === 0 || x !== x ? x : (x < 0 ? -1 : 1);
+};
+
+export const sin = Math.sin;
+
+export const sqrt = Math.sqrt;
+
+export const tan = Math.tan;
+
+export const trunc = Math.trunc ? Math.trunc : function(x) {
+  return x < 0 ? Math.ceil(x) : Math.floor(x);
+}