Skip to content

Conversation

@mmorel-35
Copy link
Contributor

Description

Update Bazel workspace dependencies to 7.6.2 compatibility with MODULE.bazel support

@mpwarres
Copy link

Thanks for the PR! LGTM, but we will need @PiotrSikora 's review and approval as the owner.

The msrv workflow is failing due to:

error: package `quote v1.0.42` cannot be built because it requires rustc 1.68 or newer, while the currently active rustc version is 1.65.0

Seems we could either revert the quote version bump in this PR, or else change the rust.yml workflow to use a more recent Rust toolchain. @PiotrSikora WDYT?

@mmorel-35
Copy link
Contributor Author

Let's rollback cargo versions modification and focus on Bazel MODULE support

@PiotrSikora
Copy link
Member

There is also a question whether we want to support the old WORKSPACE-based model. If we do, then I think we should add it to the CI to make sure it works.

@mmorel-35 mmorel-35 force-pushed the update-deps branch 3 times, most recently from 78df173 to 6ad06d1 Compare November 25, 2025 18:21
@mmorel-35
Copy link
Contributor Author

I believe it's better to start by updating dependencies and then provide the MODULE.bazel. I opened #334

You probably want to support MODULE and WORKSPACE for some few minor versions to allow the users of your library to migrate smoothly

Copy link
Member

@PiotrSikora PiotrSikora left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for cleaning this up!

But it's now clear that this should be 2 PRs: updating rules_cc, and adding support for MODULE.bazel (unless they are somehow intertwined, but it doesn't look like it).

Could you split them? Thank you!

@mmorel-35 mmorel-35 marked this pull request as draft November 26, 2025 17:20
@mmorel-35 mmorel-35 force-pushed the update-deps branch 6 times, most recently from f9adc39 to aefc51a Compare November 29, 2025 22:47
@mmorel-35 mmorel-35 changed the title Update Bazel workspace dependencies to 7.6.2 compatibility with MODULE.bazel support Provide MODULE.bazel support Nov 29, 2025
@mmorel-35 mmorel-35 force-pushed the update-deps branch 2 times, most recently from 0290615 to 2c1e239 Compare November 29, 2025 23:42
Copy link
Member

@PiotrSikora PiotrSikora left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We need to test both: WORKSPACE-based and Bzlmod workflows in the CI.

@mmorel-35 mmorel-35 force-pushed the update-deps branch 5 times, most recently from 06ebead to c784910 Compare December 1, 2025 06:04
@mmorel-35 mmorel-35 force-pushed the update-deps branch 2 times, most recently from 324c649 to 0562a23 Compare December 1, 2025 06:31
@mmorel-35 mmorel-35 marked this pull request as ready for review December 1, 2025 06:32
@mmorel-35 mmorel-35 requested a review from PiotrSikora December 1, 2025 17:27
@mmorel-35 mmorel-35 force-pushed the update-deps branch 3 times, most recently from 2989063 to 57b514d Compare December 1, 2025 18:58
@mmorel-35 mmorel-35 force-pushed the update-deps branch 4 times, most recently from c1883f2 to 1dad1a8 Compare December 3, 2025 05:59
@mmorel-35 mmorel-35 requested a review from PiotrSikora December 3, 2025 06:36
@mmorel-35
Copy link
Contributor Author

Is theŕe something left to do here ?

@PiotrSikora
Copy link
Member

Is theŕe something left to do here ?

Nope (sans one nit), but I was busy with other stuff and didn't get a chance to look at this until now.

Signed-off-by: Matthieu MOREL <matthieu.morel35@gmail.com>
@PiotrSikora PiotrSikora changed the title Provide MODULE.bazel support Add support for Bazel modules. Dec 5, 2025
Copy link
Member

@PiotrSikora PiotrSikora left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

@PiotrSikora PiotrSikora merged commit a13c1c7 into proxy-wasm:main Dec 5, 2025
42 of 44 checks passed
@mmorel-35 mmorel-35 deleted the update-deps branch December 5, 2025 08:02
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants