Don't add newline when pasting into empty buffer #2037
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- In the vi key bindings, when pasting text after the cursor in an empty buffer, a leading newline character was being added. This change removes that newline when pasting into an empty buffer.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In VI mode, hen I paste from the clipboard something that was copied line-style, (e.g. with
yy, orggVGd), the pasting process leaves an empty line above the pasted content. While that may be the expected behaviour, as pasting a linewise selection (withp) pastes it below generally, I'd argue for an exception in this case. I suggest that when pasting a command into an empty buffer, line-wise or otherwise, folks don't actually want a blank line on top that's not part of the actual copied text. This edits the vi-mode binding forpso that it doesn't leave an initial newline when pasting into the empty buffer (it does however, leave any newlines that were already in the selection, since they were intentionally copied (presumably). I think this should be implemented as the default behavior. Hope submitting a pull request is the right way to suggest this change! If not, please let me know. Thanks!