Commit 14863ae
Make VERSION tuple numeric.
Note that by being numeric we drop the rc/a/b/dev suffix.
I'm also adding the pep440 regular expression to make sure the version
number match the spec.
The pep 440 spec is a bit annoying with the fact that a/b/rc don't have
dots, but .dev do.
There are some issues if you don't follow the spec and publish both whl/tgz, as
pip will mix-up the values, and think the tgz are actually a more recent
version than the whl. It may be fixed in setuptools/pip, but better be
safe.
Ii did not go the route of setting VERSION and having __version__ be a
'.'.join() as setup.py use regex to extract version number.
Maye docs/conf.py could also use the same trick as setup.py to avoid
having to update the version number in multiple places ?
Closes #17071 parent 4b4c56d commit 14863ae
1 file changed
+10
-1
lines changed| Original file line number | Diff line number | Diff line change | |
|---|---|---|---|
| |||
13 | 13 | | |
14 | 14 | | |
15 | 15 | | |
| 16 | + | |
| 17 | + | |
| 18 | + | |
| 19 | + | |
| 20 | + | |
| 21 | + | |
| 22 | + | |
16 | 23 | | |
17 | 24 | | |
18 | 25 | | |
19 | 26 | | |
20 | 27 | | |
21 | 28 | | |
22 | 29 | | |
| 30 | + | |
| 31 | + | |
23 | 32 | | |
24 | | - | |
| 33 | + | |
25 | 34 | | |
26 | 35 | | |
27 | 36 | | |
| |||
0 commit comments