Skip to content

Commit af479c0

Browse files
committed
Fix installed pkgconfig files using wrong linker argument
for some unknown reason I used "-l:<lib>" in the .pc files while it should just be "-l<lib>". This would prevent libprojectM (and the playlist lib) from being linked in projects using pkgconfig.
1 parent 834acc3 commit af479c0

File tree

4 files changed

+4
-4
lines changed

4 files changed

+4
-4
lines changed

cmake/GeneratePkgConfigFiles.cmake

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -23,7 +23,7 @@ macro(GENERATE_PKG_CONFIG_FILES target package_name)
2323
endforeach()
2424
endif()
2525

26-
# Get name for "-l:<name>" linker flags
26+
# Get name for "-l<name>" linker flags
2727
get_target_property(_lib_name ${target} OUTPUT_NAME)
2828

2929
# Using different package name for debug and release, as pkg-config doesn't support

cmake/pkgconfig-file.in

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -9,5 +9,5 @@ Name: @PKGCONFIG_PACKAGE_NAME@
99
Version: @PROJECT_VERSION@
1010
Description: @PKGCONFIG_PACKAGE_DESCRIPTION@
1111
Requires: @PKGCONFIG_PACKAGE_REQUIREMENTS@
12-
Libs: -L${libdir} -l:@PKGCONFIG_PROJECTM_LIBRARY@ @PKGCONFIG_LIBS@
12+
Libs: -L${libdir} -l@PKGCONFIG_PROJECTM_LIBRARY@ @PKGCONFIG_LIBS@
1313
Cflags: -I${includedir} @PKGCONFIG_FLAGS@

src/libprojectM/CMakeLists.txt

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -211,7 +211,7 @@ if(ENABLE_INSTALL)
211211
# into pkgconfig's expected format.
212212
# We will just assume the build uses Boost from the default location (e.g. not a custom CMAKE_PREFIX_PATH) and
213213
# the library name is correct.
214-
set(PKGCONFIG_LIBS "${PKGCONFIG_LIBS} -l:boost_filesystem")
214+
set(PKGCONFIG_LIBS "${PKGCONFIG_LIBS} -lboost_filesystem")
215215
endif()
216216

217217
set(PKGCONFIG_PACKAGE_NAME "${PROJECTM_LIBRARY_BASE_OUTPUT_NAME}")

src/playlist/CMakeLists.txt

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -158,7 +158,7 @@ if(ENABLE_INSTALL)
158158
# into pkgconfig's expected format.
159159
# We will just assume the build uses Boost from the default location (e.g. not a custom CMAKE_PREFIX_PATH) and
160160
# the library name is correct.
161-
set(PKGCONFIG_LIBS "${PKGCONFIG_LIBS} -l:boost_filesystem")
161+
set(PKGCONFIG_LIBS "${PKGCONFIG_LIBS} -lboost_filesystem")
162162
endif()
163163

164164
set(PKGCONFIG_PACKAGE_NAME "${PROJECTM_LIBRARY_BASE_OUTPUT_NAME}-playlist")

0 commit comments

Comments
 (0)