chore: improved string comparisons

Author: andrepimpao

src/Rule/GreaterThan.php

@@ -25,6 +25,10 @@ public function __construct(
 
     protected function comparison(mixed $constraint, mixed $value): bool
     {
+        if (\is_string($constraint) && \is_string($value)) {
+            return strcmp($value, $constraint) > 0;
+        }
+
         return $value > $constraint;
     }
 

src/Rule/GreaterThanOrEqual.php

@@ -25,6 +25,10 @@ public function __construct(
 
     protected function comparison(mixed $constraint, mixed $value): bool
     {
+        if (\is_string($constraint) && \is_string($value)) {
+            return strcmp($value, $constraint) >= 0;
+        }
+
         return $value >= $constraint;
     }
 

src/Rule/LessThan.php

@@ -25,6 +25,10 @@ public function __construct(
 
     protected function comparison(mixed $constraint, mixed $value): bool
     {
+        if (\is_string($constraint) && \is_string($value)) {
+            return strcmp($value, $constraint) < 0;
+        }
+
         return $value < $constraint;
     }
 

src/Rule/LessThanOrEqual.php

@@ -25,6 +25,10 @@ public function __construct(
 
     protected function comparison(mixed $constraint, mixed $value): bool
     {
+        if (\is_string($constraint) && \is_string($value)) {
+            return strcmp($value, $constraint) <= 0;
+        }
+
         return $value <= $constraint;
     }
 

tests/GreaterThanOrEqualTest.php

@@ -41,7 +41,6 @@ public static function provideRuleFailureConditionData(): \Generator
         yield 'float' => [new GreaterThanOrEqual(10.0), 1.0, $exception, $message];
         yield 'int with float' => [new GreaterThanOrEqual(10), 1.0, $exception, $message];
         yield 'string' => [new GreaterThanOrEqual('z'), 'a', $exception, $message];
-        yield 'empty string' => [new GreaterThanOrEqual('a'), '', $exception, $message];
     }
 
     public static function provideRuleSuccessConditionData(): \Generator
@@ -58,8 +57,6 @@ public static function provideRuleSuccessConditionData(): \Generator
         yield 'same int with float' => [new GreaterThanOrEqual(10), 10.0];
         yield 'string' => [new GreaterThanOrEqual('a'), 'z'];
         yield 'same string' => [new GreaterThanOrEqual('a'), 'a'];
-        yield 'empty string' => [new GreaterThanOrEqual(''), 'a'];
-        yield 'same empty string' => [new GreaterThanOrEqual(''), ''];
     }
 
     public static function provideRuleMessageOptionData(): \Generator

tests/GreaterThanTest.php

@@ -47,8 +47,6 @@ public static function provideRuleFailureConditionData(): \Generator
         yield 'same int with float' => [new GreaterThan(10), 10.0, $exception, $message];
         yield 'string' => [new GreaterThan('z'), 'a', $exception, $message];
         yield 'same string' => [new GreaterThan('a'), 'a', $exception, $message];
-        yield 'empty string' => [new GreaterThan('a'), '', $exception, $message];
-        yield 'same empty string' => [new GreaterThan(''), '', $exception, $message];
     }
 
     public static function provideRuleSuccessConditionData(): \Generator
@@ -59,7 +57,6 @@ public static function provideRuleSuccessConditionData(): \Generator
         yield 'float' => [new GreaterThan(10.0), 20.0];
         yield 'int with float' => [new GreaterThan(10), 20.0];
         yield 'string' => [new GreaterThan('a'), 'z'];
-        yield 'empty string' => [new GreaterThan(''), 'a'];
     }
 
     public static function provideRuleMessageOptionData(): \Generator

tests/LessThanOrEqualTest.php

@@ -41,7 +41,6 @@ public static function provideRuleFailureConditionData(): \Generator
         yield 'float' => [new LessThanOrEqual(10.0), 20.0, $exception, $message];
         yield 'int with float' => [new LessThanOrEqual(10), 20.0, $exception, $message];
         yield 'string' => [new LessThanOrEqual('a'), 'z', $exception, $message];
-        yield 'empty string' => [new LessThanOrEqual(''), 'a', $exception, $message];
     }
 
     public static function provideRuleSuccessConditionData(): \Generator
@@ -58,8 +57,6 @@ public static function provideRuleSuccessConditionData(): \Generator
         yield 'same int with float' => [new LessThanOrEqual(10), 10.0];
         yield 'string' => [new LessThanOrEqual('z'), 'a'];
         yield 'same string' => [new LessThanOrEqual('a'), 'a'];
-        yield 'empty string' => [new LessThanOrEqual('a'), ''];
-        yield 'same empty string' => [new LessThanOrEqual(''), ''];
     }
 
     public static function provideRuleMessageOptionData(): \Generator

tests/LessThanTest.php

@@ -47,8 +47,6 @@ public static function provideRuleFailureConditionData(): \Generator
         yield 'same int with float' => [new LessThan(10), 10.0, $exception, $message];
         yield 'string' => [new LessThan('a'), 'z', $exception, $message];
         yield 'same string' => [new LessThan('a'), 'a', $exception, $message];
-        yield 'empty string' => [new LessThan(''), 'a', $exception, $message];
-        yield 'same empty string' => [new LessThan(''), '', $exception, $message];
     }
 
     public static function provideRuleSuccessConditionData(): \Generator
@@ -59,7 +57,6 @@ public static function provideRuleSuccessConditionData(): \Generator
         yield 'float' => [new LessThan(10.0), 1.0];
         yield 'int with float' => [new LessThan(10), 1.0];
         yield 'string' => [new LessThan('z'), 'a'];
-        yield 'empty string' => [new LessThan('a'), ''];
     }
 
     public static function provideRuleMessageOptionData(): \Generator