✅ add tests for folder filename

Author: ghalestrilo

client/components/__test__/FileNode.test.jsx

@@ -6,15 +6,52 @@ beforeAll(() => {});
 describe('<FileNode />', () => {
   let component;
   let props = {};
+  let input;
+  let renameTriggerButton;
+  const changeName = (newFileName) => {
+    renameTriggerButton.simulate('click');
+    input.simulate('change', { target: { value: newFileName } });
+    input.simulate('blur');
+  };
+  const getState = () => component.state();
+  const getUpdatedName = () => getState().updatedName;
 
-  describe('with valid props', () => {
+  describe('with valid props, regardless of filetype', () => {
+    [''].forEach((fileType) => {
+      beforeEach(() => {
+        props = {
+          ...props,
+          id: '0',
+          name: 'test.jsx',
+          fileType,
+          canEdit: true,
+          children: [],
+          authenticated: false,
+          setSelectedFile: jest.fn(),
+          deleteFile: jest.fn(),
+          updateFileName: jest.fn(),
+          resetSelectedFile: jest.fn(),
+          newFile: jest.fn(),
+          newFolder: jest.fn(),
+          showFolderChildren: jest.fn(),
+          hideFolderChildren: jest.fn(),
+          openUploadFileModal: jest.fn()
+        };
+        component = shallow(<FileNode {...props} />);
+      });
+    });
+  });
+
+  describe('as file with valid props', () => {
     beforeEach(() => {
       props = {
         ...props,
         id: '0',
-        children: [],
         name: 'test.jsx',
-        fileType: 'dunno',
+        fileType: 'file',
+        canEdit: true,
+        children: [],
+        authenticated: false,
         setSelectedFile: jest.fn(),
         deleteFile: jest.fn(),
         updateFileName: jest.fn(),
@@ -23,22 +60,12 @@ describe('<FileNode />', () => {
         newFolder: jest.fn(),
         showFolderChildren: jest.fn(),
         hideFolderChildren: jest.fn(),
-        canEdit: true,
-        authenticated: false,
         openUploadFileModal: jest.fn()
       };
       component = shallow(<FileNode {...props} />);
     });
 
     describe('when changing name', () => {
-      let input;
-      let renameTriggerButton;
-      const changeName = (newFileName) => {
-        renameTriggerButton.simulate('click');
-        input.simulate('change', { target: { value: newFileName } });
-        input.simulate('blur');
-      };
-
       beforeEach(() => {
         input = component.find('.sidebar__file-item-input');
         renameTriggerButton = component
@@ -55,17 +82,88 @@ describe('<FileNode />', () => {
         beforeEach(() => changeName(newName));
 
         it('should save the name', () => {
+          console.log('component.state');
+          console.log(component.state());
           expect(props.updateFileName).toBeCalledWith(props.id, newName);
         });
       });
 
+      // Failure Scenarios
+
       describe('to an empty filename', () => {
         const newName = '';
         beforeEach(() => changeName(newName));
 
-        it('should not save the name', () => {
-          expect(props.updateFileName).not.toHaveBeenCalled();
-        });
+
+        it('should not save', () => expect(props.updateFileName).not.toHaveBeenCalled());
+        it('should reset name', () => expect(getUpdatedName()).toEqual(props.name));
+      });
+
+      describe('to an extensionless filename', () => {
+        const newName = 'extensionless';
+        beforeEach(() => changeName(newName));
+
+        it('should not save', () => expect(props.updateFileName).not.toHaveBeenCalled());
+        it('should reset name', () => expect(getUpdatedName()).toEqual(props.name));
+      });
+
+      describe('to different extension', () => {
+        const newName = 'name.gif';
+        beforeEach(() => changeName(newName));
+
+        it('should not save', () => expect(props.updateFileName).not.toHaveBeenCalled());
+        it('should reset name', () => expect(getUpdatedName()).toEqual(props.name));
+      });
+
+      describe('to just an extension', () => {
+        const newName = '.jsx';
+        beforeEach(() => changeName(newName));
+
+        it('should not save', () => expect(props.updateFileName).not.toHaveBeenCalled());
+        it('should reset name', () => expect(getUpdatedName()).toEqual(props.name));
+      });
+    });
+  });
+
+
+  describe('as folder with valid props', () => {
+    beforeEach(() => {
+      props = {
+        ...props,
+        id: '0',
+        children: [],
+        name: 'filename',
+        fileType: 'folder',
+        canEdit: true,
+        authenticated: false,
+        setSelectedFile: jest.fn(),
+        deleteFile: jest.fn(),
+        updateFileName: jest.fn(),
+        resetSelectedFile: jest.fn(),
+        newFile: jest.fn(),
+        newFolder: jest.fn(),
+        showFolderChildren: jest.fn(),
+        hideFolderChildren: jest.fn(),
+        openUploadFileModal: jest.fn()
+      };
+      component = shallow(<FileNode {...props} />);
+    });
+
+    describe('when changing name', () => {
+      beforeEach(() => {
+        input = component.find('.sidebar__file-item-input');
+        renameTriggerButton = component
+          .find('.sidebar__file-item-option')
+          .first();
+        component.setState({ isEditing: true });
+      });
+
+      describe('to a filename', () => {
+        const newName = 'filename.jsx';
+        beforeEach(() => changeName(newName));
+
+        it('should not save', () => expect(props.updateFileName).not.toHaveBeenCalled());
+        it('should reset name', () => expect(getUpdatedName()).toEqual(props.name));
       });
     });
   });