Merge pull request #771 from postmanlabs/fix/curl-data-binary-support

Added support for usage of --data-binary flag when using long format option for body type binary.

Author: VShingala

codegens/curl/lib/index.js

@@ -201,7 +201,7 @@ self = module.exports = {
             });
             break;
           case 'file':
-            snippet += indent + form('-d', format);
+            snippet += indent + (format ? '--data-binary' : '-d');
             snippet += ` ${quoteType}@${sanitize(body[body.mode].src, trim)}${quoteType}`;
             break;
           default:

codegens/curl/test/unit/convert.test.js

@@ -1144,5 +1144,37 @@ describe('curl convert function', function () {
         });
       });
     });
+
+    it('should use --data-binary when request body type is binary', function () {
+      var request = new Request({
+        'method': 'POST',
+        'header': [],
+        'body': {
+          'mode': 'file',
+          'file': {
+            'src': 'file-path/collection123.json'
+          }
+        },
+        'url': {
+          'raw': 'https://postman-echo.com/get',
+          'protocol': 'https',
+          'host': [
+            'postman-echo',
+            'com'
+          ],
+          'path': [
+            'get'
+          ]
+        }
+      });
+
+      convert(request, { longFormat: true }, function (error, snippet) {
+        if (error) {
+          expect.fail(null, null, error);
+        }
+        expect(snippet).to.be.a('string');
+        expect(snippet).to.include('--data-binary \'@file-path/collection123.json\'');
+      });
+    });
   });
 });

codegens/python-http.client/test/unit/converter.test.js

@@ -337,7 +337,7 @@ describe('Python-http.client converter', function () {
     });
 
     it('should generate valid snippets when url uses http protocol', function () {
-      var request = new sdk.Request({
+      var request = new Request({
         'method': 'GET',
         'header': [],
         'url': {