set bar textposition default to auto

 - adjust tests

Author: archmoj

src/traces/bar/attributes.js

@@ -74,7 +74,7 @@ module.exports = {
     textposition: {
         valType: 'enumerated',
         values: ['inside', 'outside', 'auto', 'none'],
-        dflt: 'none',
+        dflt: 'auto',
         arrayOk: true,
         editType: 'calc',
         description: [

src/traces/funnel/attributes.js

@@ -54,7 +54,7 @@ module.exports = {
     }),
 
     text: barAttrs.text,
-    textposition: extendFlat({}, barAttrs.textposition, {dflt: 'auto'}),
+    textposition: barAttrs.textposition,
     insidetextanchor: extendFlat({}, barAttrs.insidetextanchor, {dflt: 'middle'}),
     textangle: extendFlat({}, barAttrs.textangle, {dflt: 0}),
     textfont: barAttrs.textfont,

test/jasmine/tests/bar_test.js

@@ -125,11 +125,20 @@ describe('Bar.supplyDefaults', function() {
         expect(traceOut.width).toBeUndefined();
     });
 
-    it('should coerce textposition to none', function() {
+    it('should coerce textposition to auto', function() {
         traceIn = {
             y: [1, 2, 3]
         };
         supplyDefaults(traceIn, traceOut, defaultColor, {});
+        expect(traceOut.textposition).toBe('auto');
+    });
+
+    it('should not coerce text styling attributes when textposition is set to none', function() {
+        traceIn = {
+            textposition: 'none',
+            y: [1, 2, 3]
+        };
+        supplyDefaults(traceIn, traceOut, defaultColor, {});
         expect(traceOut.textposition).toBe('none');
         expect(traceOut.texfont).toBeUndefined();
         expect(traceOut.insidetexfont).toBeUndefined();
@@ -1715,7 +1724,7 @@ describe('A bar plot', function() {
             y: [10, 20, 30, 40],
             type: 'bar',
             text: ['T1P1', 'T1P2', 13, 14],
-            textposition: ['inside', 'outside', 'auto', 'BADVALUE'],
+            textposition: ['inside', 'outside', 'BADVALUE', 'none'],
             textfont: {
                 family: ['"comic sans"'],
                 color: ['red', 'green'],
@@ -1739,7 +1748,7 @@ describe('A bar plot', function() {
             y: [10, 20, 30, 40],
             type: 'bar',
             text: ['T1P1', 'T1P2', '13', '14'],
-            textposition: ['inside', 'outside', 'none'],
+            textposition: ['inside', 'outside', 'auto', 'none'],
             textfont: {
                 family: ['"comic sans"', 'arial'],
                 color: ['red', 'green'],

test/jasmine/tests/waterfall_test.js

@@ -116,11 +116,20 @@ describe('Waterfall.supplyDefaults', function() {
         expect(traceOut.width).toBeUndefined();
     });
 
-    it('should coerce textposition to none', function() {
+    it('should coerce textposition to auto', function() {
         traceIn = {
             y: [1, 2, 3]
         };
         supplyDefaults(traceIn, traceOut, defaultColor, {});
+        expect(traceOut.textposition).toBe('auto');
+    });
+
+    it('should not coerce text styling attributes when textposition is set to none', function() {
+        traceIn = {
+            textposition: 'none',
+            y: [1, 2, 3]
+        };
+        supplyDefaults(traceIn, traceOut, defaultColor, {});
         expect(traceOut.textposition).toBe('none');
         expect(traceOut.texfont).toBeUndefined();
         expect(traceOut.insidetexfont).toBeUndefined();
@@ -130,6 +139,7 @@ describe('Waterfall.supplyDefaults', function() {
 
     it('should not coerce textinfo when textposition is none', function() {
         traceIn = {
+            textposition: 'none',
             y: [1, 2, 3],
             textinfo: 'text'
         };
@@ -1051,7 +1061,7 @@ describe('A waterfall plot', function() {
             y: [10, 20, 30, 40],
             type: 'waterfall',
             text: ['T1P1', 'T1P2', 13, 14],
-            textposition: ['inside', 'outside', 'auto', 'BADVALUE'],
+            textposition: ['inside', 'outside', 'BADVALUE', 'none'],
             textfont: {
                 family: ['"comic sans"'],
                 color: ['red', 'green'],
@@ -1075,7 +1085,7 @@ describe('A waterfall plot', function() {
             y: [10, 20, 30, 40],
             type: 'waterfall',
             text: ['T1P1', 'T1P2', '13', '14'],
-            textposition: ['inside', 'outside', 'none'],
+            textposition: ['inside', 'outside', 'auto', 'none'],
             textfont: {
                 family: ['"comic sans"', 'arial'],
                 color: ['red', 'green'],