Adding epsilon configuration in order to pass it on to newly modified dependencies that now take these new params. The default values are set such that 3D mesh models with minute triangles are also properly included in the GL specular light reflection calculation.

Author: monfera

package.json

@@ -61,7 +61,7 @@
     "gl-line2d": "^1.3.0",
     "gl-line3d": "^1.1.0",
     "gl-mat4": "^1.1.2",
-    "gl-mesh3d": "^1.0.7",
+    "gl-mesh3d": "^1.1.0",
     "gl-plot2d": "^1.1.6",
     "gl-plot3d": "^1.5.0",
     "gl-scatter2d": "^1.0.5",

src/traces/mesh3d/convert.js

@@ -111,6 +111,8 @@ proto.update = function(data) {
         specular: data.lighting.specular,
         roughness: data.lighting.roughness,
         fresnel: data.lighting.fresnel,
+        vertexNormalsEpsilon: data.lighting.vertexnormalsepsilon,
+        faceNormalsEpsilon: data.lighting.facenormalsepsilon,
         opacity: data.opacity,
         contourEnable: data.contour.show,
         contourColor: str2RgbaArray(data.contour.color).slice(0, 3),

src/traces/mesh3d/defaults.js

@@ -54,6 +54,8 @@ module.exports = function supplyDefaults(traceIn, traceOut, defaultColor, layout
         'lighting.specular',
         'lighting.roughness',
         'lighting.fresnel',
+        'lighting.vertexnormalsepsilon',
+        'lighting.facenormalsepsilon',
         'contour.show',
         'contour.color',
         'contour.width',

src/traces/surface/attributes.js

@@ -182,6 +182,20 @@ module.exports = {
             min: 0.00,
             max: 5.00,
             dflt: 0.2
+        },
+        vertexnormalsepsilon: {
+            valType: 'number',
+            role: 'style',
+            min: 0.00,
+            max: 1,
+            dflt: 1e-12 // otherwise finely tessellated things eg. the brain will have no specular light reflection
+        },
+        facenormalsepsilon: {
+            valType: 'number',
+            role: 'style',
+            min: 0.00,
+            max: 1,
+            dflt: 1e-6 // even the brain model doesn't appear to need finer than this
         }
     },