Skip to content

Commit a7ce254

Browse files
committed
fix double click interactions for partial ranges
1 parent be1d805 commit a7ce254

File tree

2 files changed

+17
-4
lines changed

2 files changed

+17
-4
lines changed

src/plot_api/plot_api.js

Lines changed: 11 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -1843,6 +1843,17 @@ function axRangeSupplyDefaultsByPass(gd, flags, specs) {
18431843
var axIn = gd.layout[axName];
18441844
var axOut = fullLayout[axName];
18451845
axOut.autorange = axIn.autorange;
1846+
1847+
var r0 = axOut._rangeInitial0;
1848+
var r1 = axOut._rangeInitial1;
1849+
// partial range needs supplyDefaults
1850+
if(
1851+
(r0 === undefined && r1 !== undefined) ||
1852+
(r0 !== undefined && r1 === undefined)
1853+
) {
1854+
return false;
1855+
}
1856+
18461857
if(axIn.range) {
18471858
axOut.range = axIn.range.slice();
18481859
}

src/plots/cartesian/dragbox.js

Lines changed: 6 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -785,13 +785,15 @@ function makeDragBox(gd, plotinfo, x, y, w, h, ns, ew) {
785785

786786
for(i = 0; i < axList.length; i++) {
787787
ax = axList[i];
788+
var r0 = ax._rangeInitial0;
789+
var r1 = ax._rangeInitial1;
788790
var hasRangeInitial =
789-
ax._rangeInitial0 !== undefined ||
790-
ax._rangeInitial1 !== undefined;
791+
r0 !== undefined ||
792+
r1 !== undefined;
791793

792794
if((hasRangeInitial && (
793-
ax.range[0] !== ax._rangeInitial0 ||
794-
ax.range[1] !== ax._rangeInitial1
795+
(r0 !== undefined && r0 !== ax.range[0]) ||
796+
(r1 !== undefined && r1 !== ax.range[1])
795797
)) ||
796798
(!hasRangeInitial && ax.autorange !== true)
797799
) {

0 commit comments

Comments
 (0)