use null in ranges to set defaults

Author: archmoj

src/plots/cartesian/axis_defaults.js

@@ -92,18 +92,19 @@ module.exports = function handleAxisDefaults(containerIn, containerOut, coerce,
 
     setConvert(containerOut, layoutOut);
 
-    var autorangeDflt = !containerOut.isValidRange(containerIn.range);
-    if(autorangeDflt && options.reverseDflt) autorangeDflt = 'reversed';
+    coerce('minallowed');
+    coerce('maxallowed');
+    var range = coerce('range');
+
+    var autorangeDflt = containerOut.getAutorangeDflt(range, options);
+
     var autoRange = coerce('autorange', autorangeDflt);
     if(autoRange) {
         handleAutorangeOptionsDefaults(coerce);
 
         if(axType === 'linear' || axType === '-') coerce('rangemode');
     }
 
-    coerce('minallowed');
-    coerce('maxallowed');
-    coerce('range');
     containerOut.cleanRange();
 
     handleCategoryOrderDefaults(containerIn, containerOut, coerce, options);

src/plots/cartesian/set_convert.js

@@ -877,15 +877,30 @@ module.exports = function setConvert(ax, fullLayout) {
         return arrayOut;
     };
 
-    ax.isValidRange = function(range) {
+    ax.isValidRange = function(range, nullOk) {
         return (
             Array.isArray(range) &&
             range.length === 2 &&
-            isNumeric(ax.r2l(range[0])) &&
-            isNumeric(ax.r2l(range[1]))
+            ((nullOk && range[0] === null) || isNumeric(ax.r2l(range[0]))) &&
+            ((nullOk && range[1] === null) || isNumeric(ax.r2l(range[1])))
         );
     };
 
+    ax.getAutorangeDflt = function(range, options) {
+        var autorangeDflt = !ax.isValidRange(range, 'nullOk');
+        if(autorangeDflt && options && options.reverseDflt) autorangeDflt = 'reversed';
+        else if(range) {
+            if(range[0] === null && range[1] === null) {
+                autorangeDflt = true;
+            } else if(range[0] === null && range[1] !== null) {
+                autorangeDflt = 'min';
+            } else if(range[0] !== null && range[1] === null) {
+                autorangeDflt = 'max';
+            }
+        }
+        return autorangeDflt;
+    };
+
     ax.isPtWithinRange = function(d, calendar) {
         var coord = ax.c2l(d[axLetter], null, calendar);
         var r0 = ax.r2l(ax.range[0]);

src/plots/polar/layout_defaults.js

@@ -77,7 +77,13 @@ function handleDefaults(contIn, contOut, coerce, opts) {
 
         switch(axName) {
             case 'radialaxis':
-                var autoRange = coerceAxis('autorange', !axOut.isValidRange(axIn.range));
+                coerceAxis('minallowed');
+                coerceAxis('maxallowed');
+                var range = coerceAxis('range');
+
+                var autorangeDflt = axOut.getAutorangeDflt(range);
+
+                var autoRange = coerceAxis('autorange', autorangeDflt);
                 axIn.autorange = autoRange;
                 if(autoRange) {
                     handleAutorangeOptionsDefaults(coerceAxis);
@@ -86,9 +92,6 @@ function handleDefaults(contIn, contOut, coerce, opts) {
                     if(autoRange === 'reversed') axOut._m = -1;
                 }
 
-                coerceAxis('minallowed');
-                coerceAxis('maxallowed');
-                coerceAxis('range');
                 axOut.cleanRange('range', {dfltRange: [0, 1]});
                 break;
 

test/jasmine/tests/axes_test.js

@@ -718,10 +718,10 @@ describe('Test axes', function() {
         it('should set autorange to true when input range is invalid', function() {
             layoutIn = {
                 xaxis: { range: 'not-gonna-work' },
-                xaxis2: { range: [1, 2, 3] },
+                xaxis2: { range: [1] },
                 yaxis: { range: ['a', 2] },
                 yaxis2: { range: [1, 'b'] },
-                yaxis3: { range: [null, {}] }
+                yaxis3: { range: [undefined, {}] }
             };
             layoutOut._subplots.cartesian.push('x2y2', 'xy3');
             layoutOut._subplots.yaxis.push('x2', 'y2', 'y3');
@@ -750,6 +750,36 @@ describe('Test axes', function() {
             });
         });
 
+        it('should set autorange to true when range[0] and range[1] are set to null', function() {
+            layoutIn = {
+                xaxis: { range: [null, null] }
+            };
+
+            supplyLayoutDefaults(layoutIn, layoutOut, fullData);
+
+            expect(layoutOut.xaxis.autorange).toBe(true);
+        });
+
+        it('should set autorange to min when range[0] is set to null', function() {
+            layoutIn = {
+                xaxis: { range: [null, 1] }
+            };
+
+            supplyLayoutDefaults(layoutIn, layoutOut, fullData);
+
+            expect(layoutOut.xaxis.autorange).toBe('min');
+        });
+
+        it('should set autorange to max when range[1] is set to null', function() {
+            layoutIn = {
+                xaxis: { range: [1, null] }
+            };
+
+            supplyLayoutDefaults(layoutIn, layoutOut, fullData);
+
+            expect(layoutOut.xaxis.autorange).toBe('max');
+        });
+
         it('only allows rangemode with linear axes', function() {
             layoutIn = {
                 xaxis: {type: 'log', rangemode: 'tozero'},