added more logic

Author: archmoj

src/traces/mesh3d/defaults.js

@@ -39,11 +39,31 @@ module.exports = function supplyDefaults(traceIn, traceOut, defaultColor, layout
         return;
     }
 
-    var allIndices = readComponents(['i', 'j', 'k']);
-    if(allIndices === false) {
+    // three indices should be all provided or not
+    if(
+        (traceIn.i && (!traceIn.j || !traceIn.k)) ||
+        (traceIn.j && (!traceIn.k || !traceIn.i)) ||
+        (traceIn.k && (!traceIn.i || !traceIn.j))
+    ) {
         traceOut.visible = false;
         return;
     }
+
+    // test for size of indices
+    if(
+        traceIn.i && Lib.isArrayOrTypedArray(traceIn.i) &&
+        traceIn.j && Lib.isArrayOrTypedArray(traceIn.j) &&
+        traceIn.k && Lib.isArrayOrTypedArray(traceIn.k)
+    ) {
+        if( traceIn.k.length !== 0 && (
+            traceIn.i.length !== traceIn.j.length ||
+            traceIn.j.length !== traceIn.k.length)) {
+            traceOut.visible = false;
+            return;
+        }
+    }
+
+    var allIndices = readComponents(['i', 'j', 'k']);
     if(allIndices) {
         var numVertices = coords[0].length;
         allIndices.forEach(function(indices) {

test/jasmine/tests/mesh3d_test.js

@@ -76,34 +76,6 @@ describe('Test mesh3d', function() {
             expect(gd._fullData[0].visible).toBe(exp, msg);
         }
 
-        it('@gl mesh3d should be visible when the vertex array are empty', function(done) {
-            Plotly.plot(gd, [{
-                x: [],
-                y: [],
-                z: [],
-                type: 'mesh3d'
-            }])
-            .then(function() {
-                assertVisibility(false, 'not to be visible');
-            })
-            .catch(failTest)
-            .then(done);
-        });
-
-        it('@gl mesh3d should be visible when the index arrays are not provided', function(done) {
-            Plotly.plot(gd, [{
-                x: [0, 1, 0.5, 0.5],
-                y: [0, 0.5, 1, 0.5],
-                z: [0, 0.5, 0.5, 1],
-                type: 'mesh3d'
-            }])
-            .then(function() {
-                assertVisibility(false, 'not to be visible');
-            })
-            .catch(failTest)
-            .then(done);
-        });
-
         it('@gl mesh3d should be invisible when the indices are not integer', function(done) {
             Plotly.plot(gd, [{
                 x: [0, 1, 0.5, 0.5],
@@ -222,6 +194,34 @@ describe('Test mesh3d', function() {
             .catch(failTest)
             .then(done);
         });
+
+        it('@gl mesh3d should be visible when the index arrays are not provided', function(done) {
+            Plotly.plot(gd, [{
+                x: [0, 1, 0.5, 0.5],
+                y: [0, 0.5, 1, 0.5],
+                z: [0, 0.5, 0.5, 1],
+                type: 'mesh3d'
+            }])
+            .then(function() {
+                assertVisibility(true, 'to be visible');
+            })
+            .catch(failTest)
+            .then(done);
+        });
+
+        it('@gl mesh3d should be visible when the vertex array are empty', function(done) {
+            Plotly.plot(gd, [{
+                x: [],
+                y: [],
+                z: [],
+                type: 'mesh3d'
+            }])
+            .then(function() {
+                assertVisibility(true, 'not to be visible');
+            })
+            .catch(failTest)
+            .then(done);
+        });
     });
 
 });