Skip to content

Commit 5052404

Browse files
committed
Follow VSCode guidelines regarding extension and Webpack
1 parent a7c17ac commit 5052404

File tree

1 file changed

+2
-2
lines changed

1 file changed

+2
-2
lines changed

webpack.config.js

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -11,6 +11,7 @@ const path = require('path');
1111

1212
const packageConfig = JSON.parse(fs.readFileSync(path.join(__dirname, 'package.json'), 'utf8'));
1313
const externals = Object.keys(packageConfig.dependencies);
14+
externals.push('commonjs');
1415
externals.push('vscode');
1516

1617
module.exports = {
@@ -19,8 +20,7 @@ module.exports = {
1920
output: {
2021
path: path.resolve(__dirname, 'dist'),
2122
filename: 'extension.js',
22-
libraryTarget: 'umd',
23-
umdNamedDefine: true
23+
libraryTarget: 'commonjs2'
2424
},
2525
devtool: 'source-map',
2626
target: 'node',

0 commit comments

Comments
 (0)