Changed Default PIO Home port range from "8010..8100" to "45000..45999"

Author: ivankravets

CHANGELOG.md

@@ -32,6 +32,7 @@
 
 ### Miscellaneous
 
+* Changed Default PIO Home port range from "8010..8100" to "45000..45999"
 * Fixed an issue with "'platformio-ide.build' not found" (issue [#1398](https://github.com/platformio/platformio-vscode-ide/issues/1398))
 
 ## 2.5.5 (2022-10-31)

package.json

@@ -792,7 +792,7 @@
         },
         "platformio-ide.pioHomeServerHttpPort": {
           "type": "integer",
-          "description": "PIO Home server HTTP port (the default value 0 automatically assigns a free port in the range [8010..8100])"
+          "description": "PIO Home server HTTP port (the default value 0 automatically assigns a free port in the range [45000..45999])"
         },
         "platformio-ide.customPyPiIndexUrl": {
           "type": [
@@ -908,7 +908,7 @@
   },
   "dependencies": {
     "fs-plus": "~3.1.1",
-    "platformio-node-helpers": "~9.8.0",
+    "platformio-node-helpers": "~9.9.0",
     "platformio-vscode-debug": "~1.4.1"
   },
   "devDependencies": {

src/home.js

@@ -11,7 +11,6 @@ import * as pioNodeHelpers from 'platformio-node-helpers';
 import { disposeSubscriptions, notifyError } from './utils';
 import { getPIOProjectDirs, updateProjectItemState } from './project/helpers';
 import { IS_OSX } from './constants';
-import crypto from 'crypto';
 import { extension } from './main';
 import path from 'path';
 import vscode from 'vscode';
@@ -30,6 +29,29 @@ export default class PIOHome {
     );
   }
 
+  static async shutdownAllServers() {
+    await pioNodeHelpers.home.shutdownServer();
+    await pioNodeHelpers.home.shutdownAllServers();
+  }
+
+  onPanelDisposed() {
+    this._currentPanel = undefined;
+  }
+
+  disposePanel() {
+    if (!this._currentPanel) {
+      return;
+    }
+    this._currentPanel.dispose();
+    this._currentPanel = undefined;
+  }
+
+  dispose() {
+    pioNodeHelpers.home.shutdownServer();
+    this.disposePanel();
+    disposeSubscriptions(this.subscriptions);
+  }
+
   async toggle(startUrl = PIOHome.defaultStartUrl) {
     const column = vscode.window.activeTextEditor
       ? vscode.window.activeTextEditor.viewColumn
@@ -102,9 +124,7 @@ export default class PIOHome {
       onIDECommand: await this.onIDECommand.bind(this),
     });
     const theme = this.getTheme();
-    const iframeId =
-      'pioHomeIFrame-' +
-      crypto.createHash('sha1').update(crypto.randomBytes(512)).digest('hex');
+    const iframeId = `pioHomeIFrame-${vscode.env.sessionId}`;
     const iframeScript = `
 <script>
   for (const command of ['selectAll', 'copy', 'paste', 'cut', 'undo', 'redo']) {
@@ -186,22 +206,4 @@ export default class PIOHome {
   onGetPIOProjectDirs() {
     return getPIOProjectDirs();
   }
-
-  onPanelDisposed() {
-    this._currentPanel = undefined;
-  }
-
-  disposePanel() {
-    if (!this._currentPanel) {
-      return;
-    }
-    this._currentPanel.dispose();
-    this._currentPanel = undefined;
-  }
-
-  dispose() {
-    this.disposePanel();
-    disposeSubscriptions(this.subscriptions);
-    pioNodeHelpers.home.shutdownServer();
-  }
 }

src/installer/manager.js

@@ -8,6 +8,7 @@
 
 import * as pioNodeHelpers from 'platformio-node-helpers';
 
+import PIOHome from '../home';
 import { PIO_CORE_VERSION_SPEC } from '../constants';
 import PythonPrompt from './python-prompt';
 import { extension } from '../main';
@@ -84,6 +85,8 @@ export default class InstallationManager {
 
   async install(progress) {
     const stageIncrementTotal = 100 / this.stages.length;
+    // shutdown all PIO Home servers which block python.exe on Windows
+    await PIOHome.shutdownAllServers();
     for (const stage of this.stages) {
       await stage.install((message, increment) => {
         progress.report({

src/main.js

@@ -276,7 +276,7 @@ class PlatformIOVSCodeExtension {
   }
 
   handleUseDevelopmentPIOCoreConfiguration() {
-    return vscode.workspace.onDidChangeConfiguration((e) => {
+    return vscode.workspace.onDidChangeConfiguration(async (e) => {
       if (
         !e.affectsConfiguration('platformio-ide.useDevelopmentPIOCore') ||
         !this.getConfiguration('useBuiltinPIOCore')
@@ -287,18 +287,16 @@ class PlatformIOVSCodeExtension {
       if (!envDir || !fs.isDirectorySync(envDir)) {
         return;
       }
-      pioNodeHelpers.home.shutdownServer();
-      const delayedJob = () => {
-        try {
-          fs.removeSync(envDir);
-        } catch (err) {
-          console.warn(err);
-        }
-        vscode.window.showInformationMessage(
-          'Please restart VSCode to apply the changes.'
-        );
-      };
-      setTimeout(delayedJob, 2000);
+      await PIOHome.shutdownAllServers();
+      await pioNodeHelpers.misc.sleep(2000);
+      try {
+        fs.removeSync(envDir);
+      } catch (err) {
+        console.warn(err);
+      }
+      vscode.window.showInformationMessage(
+        'Please restart VSCode to apply the changes.'
+      );
     });
   }