Fixed a regression bug where running the same "monitor" causes the notification that the task "is already active" // Resolve platformio#3656

Author: ivankravets

CHANGELOG.md

@@ -1,5 +1,9 @@
 # Release Notes
 
+## 3.1.1 (2023-03-??)
+
+* Fixed a regression bug where running the same "monitor" causes the notification that the task "is already active" (issue [#3656](https://github.com/platformio/platformio-vscode-ide/issues/3656))
+
 ## 3.1.0 (2023-03-13)
 
 * Add support for the ``${command:platformio-ide.activeEnvironment}`` variable that can be used in a custom [PlatformIO Toolbar](https://docs.platformio.org/en/latest/integration/ide/vscode.html#platformio-toolbar) and [VSCode variable substitution](https://code.visualstudio.com/docs/editor/variables-reference) (issue [#3588](https://github.com/platformio/platformio-vscode-ide/issues/3588))

src/project/tasks.js

@@ -90,7 +90,6 @@ export default class ProjectTaskManager {
         },
       }),
 
-      vscode.tasks.onDidStartTask((event) => this.onDidStartTask(event)),
       vscode.tasks.onDidEndTaskProcess((event) => this.onDidEndTaskProcess(event))
     );
 
@@ -149,22 +148,15 @@ export default class ProjectTaskManager {
   }
 
   runTask(task) {
+    this._autoCloseSerialMonitor(task);
     // use string-based task defination for Win 7 // issue #3481
     vscode.commands.executeCommand(
       'workbench.action.tasks.runTask',
       `${ProjectTaskManager.PROVIDER_TYPE}: ${task.id}`
     );
   }
 
-  onDidStartTask(event) {
-    this._autoCloseSerialMonitor(event.execution.task);
-  }
-
   async _autoCloseSerialMonitor(startedTask) {
-    if (startedTask.definition.type !== ProjectTaskManager.PROVIDER_TYPE) {
-      return;
-    }
-
     this._startedTask = startedTask;
     this._tasksToRestore = [];
     const closeMonitorConds = [
@@ -186,18 +178,20 @@ export default class ProjectTaskManager {
     // }
 
     vscode.tasks.taskExecutions.forEach((event) => {
-      const isCurrentEvent = this.areTasksEqual(this._startedTask, event.task);
+      const isCurrentTask = this.areTasksEqual(this._startedTask, event.task);
       const skipConds = [
-        isCurrentEvent,
         // skip non-PlatformIO task
         event.task.definition.type !== ProjectTaskManager.PROVIDER_TYPE,
         !this.getTaskArgs(event.task).includes('monitor'),
-        this.isMonitorAndUploadTask(event.task),
+        this.isMonitorAndUploadTask(event.task) && !isCurrentTask,
       ];
       if (skipConds.some((value) => value)) {
         return;
       }
-      this._tasksToRestore.push(event.task);
+      // do not restart the same tasks
+      if (!isCurrentTask) {
+        this._tasksToRestore.push(event.task);
+      }
       event.terminate();
     });
   }